Skip to content
Snippets Groups Projects
  1. Dec 03, 2007
  2. Dec 02, 2007
    • Tom Lane's avatar
      Code review for LIKE ... INCLUDING INDEXES patch. Fix failure to propagate · 265f904d
      Tom Lane authored
      constraint status of copied indexes (bug #3774), as well as various other
      small bugs such as failure to pstrdup when needed.  Allow INCLUDING INDEXES
      indexes to be merged with identical declared indexes (perhaps not real useful,
      but the code is there and having it not apply to LIKE indexes seems pretty
      unorthogonal).  Avoid useless work in generateClonedIndexStmt().  Undo some
      poorly chosen API changes, and put a couple of routines in modules that seem
      to be better places for them.
      265f904d
  3. Nov 30, 2007
    • Tom Lane's avatar
      Avoid incrementing the CommandCounter when CommandCounterIncrement is called · 895a94de
      Tom Lane authored
      but no database changes have been made since the last CommandCounterIncrement.
      This should result in a significant improvement in the number of "commands"
      that can typically be performed within a transaction before hitting the 2^32
      CommandId size limit.  In particular this buys back (and more) the possible
      adverse consequences of my previous patch to fix plan caching behavior.
      
      The implementation requires tracking whether the current CommandCounter
      value has been "used" to mark any tuples.  CommandCounter values stored into
      snapshots are presumed not to be used for this purpose.  This requires some
      small executor changes, since the executor used to conflate the curcid of
      the snapshot it was using with the command ID to mark output tuples with.
      Separating these concepts allows some small simplifications in executor APIs.
      
      Something for the TODO list: look into having CommandCounterIncrement not do
      AcceptInvalidationMessages.  It seems fairly bogus to be doing it there,
      but exactly where to do it instead isn't clear, and I'm disinclined to mess
      with asynchronous behavior during late beta.
      895a94de
  4. Nov 28, 2007
    • Tom Lane's avatar
      Adjust the names of a couple of tsearch index support functions that had · 11fccbea
      Tom Lane authored
      inappropriately generic-sounding names.  This is more or less free since
      we already forced initdb for the next beta, and it may prevent confusion or
      name conflicts (particularly at the C-global-symbol level) down the road.
      Per my proposal yesterday.
      11fccbea
    • Tom Lane's avatar
      Install a lookaside cache to speed up repeated lookups of the same operator · d54ca567
      Tom Lane authored
      by short-circuiting schema search path and ambiguous-operator resolution
      computations.  Remarkably, this buys as much as 45% speedup of repetitive
      simple queries that involve operators that are not an exact match to the
      input datatypes.  It should be marginally faster even for exact-match
      cases, though I've not had success in proving an improvement in benchmark
      tests.  Per report from Guillame Smet and subsequent discussion.
      d54ca567
  5. Nov 27, 2007
  6. Nov 24, 2007
  7. Nov 22, 2007
  8. Nov 16, 2007
  9. Nov 15, 2007
  10. Nov 13, 2007
  11. Nov 11, 2007
    • Tom Lane's avatar
      Ensure that typmod decoration on a datatype name is validated in all cases, · 0bd4da23
      Tom Lane authored
      even in code paths where we don't pay any subsequent attention to the typmod
      value.  This seems needed in view of the fact that 8.3's generalized typmod
      support will accept a lot of bogus syntax, such as "timestamp(foo)" or
      "record(int, 42)" --- if we allow such things to pass without comment,
      users will get confused.  Per a recent example from Greg Stark.
      
      To implement this in a way that's not very vulnerable to future
      bugs-of-omission, refactor the API of parse_type.c's TypeName lookup routines
      so that typmod validation is folded into the base lookup operation.  Callers
      can still choose not to receive the encoded typmod, but we'll check the
      decoration anyway if it's present.
      0bd4da23
  12. Nov 09, 2007
  13. Nov 08, 2007
    • Tom Lane's avatar
      Fix EquivalenceClass code to handle volatile sort expressions in a more · c291203c
      Tom Lane authored
      predictable manner; in particular that if you say ORDER BY output-column-ref,
      it will in fact sort by that specific column even if there are multiple
      syntactic matches.  An example is
      	SELECT random() AS a, random() AS b FROM ... ORDER BY b, a;
      While the use-case for this might be a bit debatable, it worked as expected
      in earlier releases, so we should preserve the behavior for 8.3.  Per my
      recent proposal.
      
      While at it, fix convert_subquery_pathkeys() to handle RelabelType stripping
      in both directions; it needs this for the same reasons make_sort_from_pathkeys
      does.
      c291203c
    • Tom Lane's avatar
      Last week's patch for make_sort_from_pathkeys wasn't good enough: it has · 1be06016
      Tom Lane authored
      to be able to discard top-level RelabelType nodes on *both* sides of the
      equivalence-class-to-target-list comparison, since make_pathkey_from_sortinfo
      might either add or remove a RelabelType.  Also fix the latter to do the
      removal case cleanly.  Per example from Peter.
      1be06016
  14. Nov 07, 2007
    • Tom Lane's avatar
      Improve the performance of LIKE/regex estimation in non-C locales, by making · 2de946be
      Tom Lane authored
      make_greater_string() try harder to generate a string that's actually greater
      than its input string.  Before we just assumed that making a string that was
      memcmp-greater was enough, but it is easy to generate examples where this is
      not so when the locale is not C.  Instead, loop until the relevant comparison
      function agrees that the generated string is greater than the input.
      
      Unfortunately this is probably not enough to guarantee that the generated
      string is greater than all extensions of the input, so we cannot relax the
      restriction to C locale for the LIKE/regex index optimization.  But it should
      at least improve the odds of getting a useful selectivity estimate in
      prefix_selectivity().  Per example from Guillaume Smet.
      
      Backpatch to 8.1, mainly because that's what the complainant is using...
      2de946be
    • Peter Eisentraut's avatar
  15. Nov 05, 2007
  16. Oct 29, 2007
    • Tom Lane's avatar
      Remove the hack in the grammar that "optimized away" DEFAULT NULL clauses. · b17b7fae
      Tom Lane authored
      Instead put in a test to drop a NULL default at the last moment before
      storing the catalog entry.  This changes the behavior in a couple of ways:
      * Specifying DEFAULT NULL when creating an inheritance child table will
        successfully suppress inheritance of any default expression from the
        parent's column, where formerly it failed to do so.
      * Specifying DEFAULT NULL for a column of a domain type will correctly
        override any default belonging to the domain; likewise for a sub-domain.
      The latter change happens because by the time the clause is checked,
      it won't be a simple null Const but a CoerceToDomain expression.
      
      Personally I think this should be back-patched, but there doesn't seem to
      be consensus for that on pgsql-hackers, so refraining.
      b17b7fae
    • Magnus Hagander's avatar
      6f14effb
  17. Oct 27, 2007
  18. Oct 26, 2007
  19. Oct 25, 2007
    • Tom Lane's avatar
      Disallow scrolling of FOR UPDATE/FOR SHARE cursors, so as to avoid problems · 048efc25
      Tom Lane authored
      in corner cases such as re-fetching a just-deleted row.  We may be able to
      relax this someday, but let's find out how many people really care before
      we invest a lot of work in it.  Per report from Heikki and subsequent
      discussion.
      
      While in the neighborhood, make the combination of INSENSITIVE and FOR UPDATE
      throw an error, since they are semantically incompatible.  (Up to now we've
      accepted but just ignored the INSENSITIVE option of DECLARE CURSOR.)
      048efc25
  20. Oct 24, 2007
    • Alvaro Herrera's avatar
      Rearrange vacuum-related bits in PGPROC as a bitmask, to better support · 745c1b2c
      Alvaro Herrera authored
      having several of them.  Add two more flags: whether the process is
      executing an ANALYZE, and whether a vacuum is for Xid wraparound (which
      is obviously only set by autovacuum).
      
      Sneakily move the worker's recently-acquired PostAuthDelay to a more useful
      place.
      745c1b2c
    • Tom Lane's avatar
      Fix UPDATE/DELETE WHERE CURRENT OF to support repeated update and update- · c29a9c37
      Tom Lane authored
      then-delete on the current cursor row.  The basic fix is that nodeTidscan.c
      has to apply heap_get_latest_tid() to the current-scan-TID obtained from the
      cursor query; this ensures we get the latest row version to work with.
      However, since that only works if the query plan is a TID scan, we also have
      to hack the planner to make sure only that type of plan will be selected.
      (Formerly, the planner might decide to apply a seqscan if the table is very
      small.  This change is probably a Good Thing anyway, since it's hard to see
      how a seqscan could really win.)  That means the execQual.c code to support
      CurrentOfExpr as a regular expression type is dead code, so replace it with
      just an elog().  Also, add regression tests covering these cases.  Note
      that the added tests expose the fact that re-fetching an updated row
      misbehaves if the cursor used FOR UPDATE.  That's an independent bug that
      should be fixed later.  Per report from Dharmendra Goyal.
      c29a9c37
    • Tom Lane's avatar
      Remove the aggregate form of ts_rewrite(), since it doesn't work as desired · 592c88a0
      Tom Lane authored
      if there are zero rows to aggregate over, and the API seems both conceptually
      and notationally ugly anyway.  We should look for something that improves
      on the tsquery-and-text-SELECT version (which is also pretty ugly but at
      least it works...), but it seems that will take query infrastructure that
      doesn't exist today.  (Hm, I wonder if there's anything in or near SQL2003
      window functions that would help?)  Per discussion.
      592c88a0
  21. Oct 23, 2007
    • Tom Lane's avatar
      Make configure probe for the location of the <uuid.h> header file. · 07d0a370
      Tom Lane authored
      Needed to accommodate different layout on some platforms (Debian for
      one).  Heikki Linnakangas
      07d0a370
    • Tom Lane's avatar
      Rename and slightly redefine the default text search parser's "word" · dbaec70c
      Tom Lane authored
      categories, as per discussion.  asciiword (formerly lword) is still
      ASCII-letters-only, and numword (formerly word) is still the most general
      mixed-alpha-and-digits case.  But word (formerly nlword) is now
      any-group-of-letters-with-at-least-one-non-ASCII, rather than all-non-ASCII as
      before.  This is no worse than before for parsing mixed Russian/English text,
      which seems to have been the design center for the original coding; and it
      should simplify matters for parsing most European languages.  In particular
      it will not be necessary for any language to accept strings containing digits
      as being regular "words".  The hyphenated-word categories are adjusted
      similarly.
      dbaec70c
    • Tom Lane's avatar
      Fix two-argument form of ts_rewrite() so it actually works for cases where · 12f25e70
      Tom Lane authored
      a later rewrite rule should change a subtree modified by an earlier one.
      Per my gripe of a few days ago.
      12f25e70
  22. Oct 22, 2007
    • Tom Lane's avatar
      Adjust ts_debug's output as per my proposal of yesterday: show the · 3e17ef1c
      Tom Lane authored
      active dictionary and its output lexemes as separate columns, instead
      of smashing them into one text column, and lowercase the column names.
      Also, define the output rowtype using OUT parameters instead of a
      composite type, to be consistent with the other built-in functions.
      3e17ef1c
Loading