-
- Downloads
Ensure that typmod decoration on a datatype name is validated in all cases,
even in code paths where we don't pay any subsequent attention to the typmod value. This seems needed in view of the fact that 8.3's generalized typmod support will accept a lot of bogus syntax, such as "timestamp(foo)" or "record(int, 42)" --- if we allow such things to pass without comment, users will get confused. Per a recent example from Greg Stark. To implement this in a way that's not very vulnerable to future bugs-of-omission, refactor the API of parse_type.c's TypeName lookup routines so that typmod validation is folded into the base lookup operation. Callers can still choose not to receive the encoded typmod, but we'll check the decoration anyway if it's present.
Showing
- src/backend/access/common/tupdesc.c 2 additions, 3 deletionssrc/backend/access/common/tupdesc.c
- src/backend/commands/aggregatecmds.c 4 additions, 4 deletionssrc/backend/commands/aggregatecmds.c
- src/backend/commands/comment.c 4 additions, 4 deletionssrc/backend/commands/comment.c
- src/backend/commands/functioncmds.c 25 additions, 11 deletionssrc/backend/commands/functioncmds.c
- src/backend/commands/opclasscmds.c 5 additions, 5 deletionssrc/backend/commands/opclasscmds.c
- src/backend/commands/operatorcmds.c 3 additions, 3 deletionssrc/backend/commands/operatorcmds.c
- src/backend/commands/prepare.c 2 additions, 2 deletionssrc/backend/commands/prepare.c
- src/backend/commands/tablecmds.c 8 additions, 15 deletionssrc/backend/commands/tablecmds.c
- src/backend/commands/typecmds.c 24 additions, 33 deletionssrc/backend/commands/typecmds.c
- src/backend/parser/parse_expr.c 4 additions, 6 deletionssrc/backend/parser/parse_expr.c
- src/backend/parser/parse_func.c 54 additions, 20 deletionssrc/backend/parser/parse_func.c
- src/backend/parser/parse_oper.c 3 additions, 3 deletionssrc/backend/parser/parse_oper.c
- src/backend/parser/parse_relation.c 2 additions, 3 deletionssrc/backend/parser/parse_relation.c
- src/backend/parser/parse_type.c 170 additions, 140 deletionssrc/backend/parser/parse_type.c
- src/backend/parser/parse_utilcmd.c 2 additions, 2 deletionssrc/backend/parser/parse_utilcmd.c
- src/backend/utils/misc/guc.c 4 additions, 2 deletionssrc/backend/utils/misc/guc.c
- src/include/parser/parse_type.h 10 additions, 9 deletionssrc/include/parser/parse_type.h
- src/pl/plpgsql/src/pl_comp.c 15 additions, 23 deletionssrc/pl/plpgsql/src/pl_comp.c
Loading
Please register or sign in to comment