Skip to content
Snippets Groups Projects
  1. Sep 03, 2010
  2. Sep 02, 2010
    • Tom Lane's avatar
      Fix up flushing of composite-type typcache entries to be driven directly by · 9513918c
      Tom Lane authored
      SI invalidation events, rather than indirectly through the relcache.
      
      In the previous coding, we had to flush a composite-type typcache entry
      whenever we discarded the corresponding relcache entry.  This caused problems
      at least when testing with RELCACHE_FORCE_RELEASE, as shown in recent report
      from Jeff Davis, and might result in real-world problems given the kind of
      unexpected relcache flush that that test mechanism is intended to model.
      
      The new coding decouples relcache and typcache management, which is a good
      thing anyway from a structural perspective.  The cost is that we have to
      search the typcache linearly to find entries that need to be flushed.  There
      are a couple of ways we could avoid that, but at the moment it's not clear
      it's worth any extra trouble, because the typcache contains very few entries
      in typical operation.
      
      Back-patch to 8.2, the same as some other recent fixes in this general area.
      The patch could be carried back to 8.0 with some additional work, but given
      that it's only hypothetical whether we're fixing any problem observable in
      the field, it doesn't seem worth the work now.
      9513918c
    • Robert Haas's avatar
      Fix typo. Pointed out by Kevin Grittner. · f3c903f8
      Robert Haas authored
      f3c903f8
  3. Aug 30, 2010
  4. Aug 29, 2010
    • Tom Lane's avatar
      Reduce PANIC to ERROR in some occasionally-reported btree failure cases. · 8fa30f90
      Tom Lane authored
      This patch changes _bt_split() and _bt_pagedel() to throw a plain ERROR,
      rather than PANIC, for several cases that are reported from the field
      from time to time:
      * right sibling's left-link doesn't match;
      * PageAddItem failure during _bt_split();
      * parent page's next child isn't right sibling during _bt_pagedel().
      In addition the error messages for these cases have been made a bit
      more verbose, with additional values included.
      
      The original motivation for PANIC here was to capture core dumps for
      subsequent analysis.  But with so many users whose platforms don't capture
      core dumps by default, or who are unprepared to analyze them anyway, it's hard
      to justify a forced database restart when we can fairly easily detect the
      problems before we've reached the critical sections where PANIC would be
      necessary.  It is not currently known whether the reports of these messages
      indicate well-hidden bugs in Postgres, or are a result of storage-level
      malfeasance; the latter possibility suggests that we ought to try to be more
      robust even if there is a bug here that's ultimately found.
      
      Backpatch to 8.2.  The code before that is sufficiently different that
      it doesn't seem worth the trouble to back-port further.
      8fa30f90
  5. Aug 27, 2010
  6. Aug 26, 2010
  7. Aug 25, 2010
    • Tom Lane's avatar
      Improve hint message for ENOMEM failure from shmget(). · acac35ad
      Tom Lane authored
      It turns out that some platforms return ENOMEM for a request that violates
      SHMALL, whereas we were assuming that ENOSPC would always be used for that.
      Apparently the latter is a Linuxism while ENOMEM is the BSD tradition.
      Extend the ENOMEM hint to suggest that raising SHMALL might be needed.
      Per gripe from A.M.
      
      Backpatch to 9.0, but not further, because this doesn't seem important
      enough to warrant creating extra translation work in the stable branches.
      (If it were, we'd have figured this out years ago.)
      acac35ad
    • Peter Eisentraut's avatar
      Catch null pointer returns from PyCObject_AsVoidPtr and PyCObject_FromVoidPtr · c76a4f8d
      Peter Eisentraut authored
      This is reproducibly possible in Python 2.7 if the user turned
      PendingDeprecationWarning into an error, but it's theoretically also possible
      in earlier versions in case of exceptional conditions.
      
      backpatched to 8.0
      c76a4f8d
    • Tom Lane's avatar
      Avoid passing signed chars to <ctype.h> functions ... same old · 1dab218a
      Tom Lane authored
      portability mistake as always.  Per buildfarm member pika.
      1dab218a
  8. Aug 24, 2010
  9. Aug 23, 2010
    • Tom Lane's avatar
      Marginal code cleanup for streaming replication. · b9defe04
      Tom Lane authored
      There is no reason that proc.c should have to get involved in this dirty hack
      for letting the postmaster know which children are walsenders.  Revert that
      file to the way it was, and confine the kluge to pmsignal.c and postmaster.c.
      b9defe04
  10. Aug 21, 2010
    • Tom Lane's avatar
      Use a non-locale-dependent definition of isspace() in array_in/array_out. · 95cacd13
      Tom Lane authored
      array_in discards unquoted leading and trailing whitespace in array values,
      while array_out is careful to quote array elements that contain whitespace.
      This is problematic when the definition of "whitespace" varies between
      locales: array_in could drop characters that were meant to be part of the
      value.  To avoid that, lock down "whitespace" to mean only the traditional
      six ASCII space characters.
      
      This change also works around a bug in OS X and some older BSD systems, in
      which isspace() could return true for character fragments in UTF8 locales.
      (There may be other places in PG where that bug could cause problems, but
      this is the only one complained of so far; see recent report from Steven
      Schlansker.)
      
      Back-patch to 9.0, but not further.  Given the lack of previous reports
      of trouble, changing this behavior in stable branches seems to offer
      more risk of breaking applications than reward of avoiding problems.
      95cacd13
    • Tom Lane's avatar
      Improve parallel restore's ability to cope with selective restore (-L option). · c5d6d5bc
      Tom Lane authored
      The original coding tended to break down in the face of modified restore
      orders, as shown in bug #5626 from Albert Ullrich, because it would flip over
      into parallel-restore operation too soon.  That causes problems because we
      don't have sufficient dependency information in dump archives to allow safe
      parallel processing of SECTION_PRE_DATA items.  Even if we did, it's probably
      undesirable to allow that to override the commanded restore order.
      
      To fix the problem of omitted items causing unexpected changes in restore
      order, tweak SortTocFromFile so that omitted items end up at the head of
      the list not the tail.  This ensures that they'll be examined and their
      dependencies will be marked satisfied before we get to any interesting
      items.
      
      In HEAD and 9.0, we can easily change restore_toc_entries_parallel so that
      all SECTION_PRE_DATA items are guaranteed to be processed in the initial
      serial-restore loop, and hence in commanded order.  Only DATA and POST_DATA
      items are candidates for parallel processing.  For them there might be
      variations from the commanded order because of parallelism, but we should
      do it in a safe order thanks to dependencies.
      
      In 8.4 it's much harder to make such a guarantee.  I settled for not
      letting the initial loop break out into parallel processing mode if
      it sees a DATA/POST_DATA item that's not to be restored; this at least
      prevents a non-restorable item from causing premature exit from the loop.
      This means that 8.4 will be more likely to fail given a badly-ordered -L
      list than 9.x, but we don't really promise any such thing will work anyway.
      c5d6d5bc
    • Magnus Hagander's avatar
      Adjust regression tests for previous commit, that I forgot · 5abd2d70
      Magnus Hagander authored
      to include...
      5abd2d70
    • Magnus Hagander's avatar
  11. Aug 20, 2010
  12. Aug 19, 2010
    • Tom Lane's avatar
      Allow USING and INTO clauses of plpgsql's EXECUTE to appear in either order. · 9676b010
      Tom Lane authored
      Aside from being more forgiving, this prevents a rather surprising misbehavior
      when the "wrong" order was used: the old code didn't throw a syntax error,
      but absorbed the INTO clause into the last USING expression, which then did
      strange things downstream.
      
      Intentionally not changing the documentation; we'll continue to advertise
      only the "standard" clause order.
      
      Backpatch to 8.4, where the USING clause was added to EXECUTE.
      9676b010
    • Tom Lane's avatar
      Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple. · f4b4a46f
      Tom Lane authored
      It's not clear if this situation can occur in plpgsql other than via the
      EXECUTE USING case Heikki illustrated, which I will shortly close off.
      However, ignoring the intoClause if it's there is surely wrong, so let's
      patch it for safety.
      
      Backpatch to 8.3, which is as far back as this code has a PlannedStmt
      to deal with.  There might be another way to make an equivalent test
      before that, but since this is just preventing hypothetical bugs,
      I'm not going to obsess about it.
      f4b4a46f
    • Tom Lane's avatar
    • Heikki Linnakangas's avatar
      Revert patch to coerce 'unknown' type parameters in the backend. As Tom · ff645bf5
      Heikki Linnakangas authored
      pointed out, it would need a 2nd pass after the whole query is processed to
      correctly check that an unknown Param is coerced to the same target type
      everywhere. Adding the 2nd pass would add a lot more code, which doesn't
      seem worth the risk given that there isn't much of a use case for passing
      unknown Params in the first place. The code would work without that check,
      but it might be confusing and the behavior would be different from the
      varparams case.
      
      Instead, just coerce all unknown params in a PL/pgSQL USING clause to text.
      That's simple, and is usually what users expect.
      
      Revert the patch in CVS HEAD and master, and backpatch the new solution to
      8.4. Unlike the previous solution, this applies easily to 8.4 too.
      ff645bf5
    • Tom Lane's avatar
      Allocate local buffers in a context of their own, rather than dumping them · bc7cb8f4
      Tom Lane authored
      into TopMemoryContext.  This makes no functional difference, but makes it
      easier to see what the space is being used for in MemoryContextStats dumps.
      Per a recent example in which I was surprised by the size of TopMemoryContext.
      bc7cb8f4
    • Tom Lane's avatar
      Fix possible corruption of AfterTriggerEventLists in subtransaction rollback. · e275d16a
      Tom Lane authored
      afterTriggerInvokeEvents failed to adjust events->tailfree when truncating
      the last chunk of an event list.  This could result in the data being
      "de-truncated" by afterTriggerRestoreEventList during a subsequent
      subtransaction abort.  Even that wouldn't kill us, because the re-added data
      would just be events marked DONE --- unless the data had been partially
      overwritten by new events.  Then we might crash, or in any case misbehave
      (perhaps fire triggers twice, or fire triggers with the wrong event data).
      Per bug #5622 from Thue Janus Kristensen.
      
      Back-patch to 8.4 where the current trigger list representation was introduced.
      e275d16a
    • Peter Eisentraut's avatar
      3f119719
    • Robert Haas's avatar
      Tidy up a few calls to smrgextend(). · d37781fa
      Robert Haas authored
      In the new API introduced by my patch to include the backend ID in
      temprel filenames, the last argument to smrgextend() became skipFsync
      rather than isTemp, but these calls didn't get the memo.  It's not
      really a problem to pass rel->rd_istemp rather than just plain false,
      because smgrextend() now automatically skips the fsync for temprels
      anyway, but this seems cleaner and saves some minute number of cycles.
      d37781fa
Loading