- Nov 05, 2005
-
-
Tom Lane authored
-
Peter Eisentraut authored
-
- Nov 04, 2005
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
Tom Lane authored
so as to avoid performance issues and possible ultimate crash on long psql scripts. Per Merlin Moncure.
-
Tom Lane authored
create circularity of role memberships. This is a minimum-impact fix for the problem reported by Florian Pflug. I thought about removing the superuser_arg test from is_member_of_role() altogether, as it seems redundant for many of the callers --- but not all, and it's way too late in the 8.1 cycle to be making large changes. Perhaps reconsider this later.
-
- Nov 03, 2005
-
-
Tom Lane authored
-
Alvaro Herrera authored
-
Tom Lane authored
to ensure that SubqueryScan elimination doesn't change the behavior of reporting of original column sources.
-
Tom Lane authored
from a finished plan tree. We have to copy the output column names (resname fields) from the SubqueryScan down to its child plan node; else, if this is the topmost level of the plan, the wrong column names will be delivered to the client. Per bug #2017 reported by Jolly Chen.
-
Alvaro Herrera authored
those names. (Debug and None were pretty bad names anyway.) I hope I catched all uses of the names in comments too.
-
Alvaro Herrera authored
-
Tom Lane authored
very narrow window in which SimpleLruReadPage or SimpleLruWritePage could think that I/O was needed when it wasn't (and indeed the buffer had already been assigned to another page). This would result in an Assert failure if Asserts were enabled, and probably in silent data corruption if not. Reported independently by Jim Nasby and Robert Creager. I intend a more extensive fix when 8.2 development starts, but this is a reasonably low-impact patch for the existing branches.
-
- Nov 01, 2005
-
-
Andrew Dunstan authored
Provide a --no-locale option for pg_regress and a corresponding NOLOCALE=1 setting for the regression makefile, allowing Windows users to force locale settings since Windows does not get its locale from the environment. Per Petr Jelinek.
-
- Oct 29, 2005
-
-
Tom Lane authored
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
- Oct 28, 2005
-
-
Tom Lane authored
reserving SLRU space for a new MultiXact. The original coding would have treated out-of-disk-space as a PANIC condition, which is unnecessary.
-
Tom Lane authored
of postgres.imp file into BE_DLLLIBS macro. This makes the AIX build work more like the Windows and Darwin builds, which have similar requirements to mention a backend library when linking shared libraries that will be dynamically loaded into the backend.
-
Tom Lane authored
multixact's starting offset before the offset has been stored into the SLRU file. A simple fix would be to hold the MultiXactGenLock until the offset has been stored, but that looks like a big concurrency hit. Instead rely on knowledge that unset offsets will be zero, and loop when we see a zero. This requires a little extra hacking to ensure that zero is never a valid value for the offset. Problem reported by Matteo Beccati, fix ideas from Martijn van Oosterhout, Alvaro Herrera, and Tom Lane.
-
- Oct 27, 2005
-
-
Tom Lane authored
for postgres: on line 86, and line 43 shouldn't be used. Noted while looking at kookaburra buildfarm results.
-
Tom Lane authored
advance its usage_count. This includes writes of dirty buffers triggered by bgwriter, checkpoint, or FlushRelationBuffers, as well as various corner cases that really ought not count as accesses to the page. Should make for some marginal improvement in the quality of our decisions about when to recycle buffers. Per suggestion from ITAGAKI Takahiro.
-
Bruce Momjian authored
commands. Per complaint that \df+ is clearer in expanded mode.
-
Bruce Momjian authored
interval_justify_hours in timestamp subtraction. TODO already has text description.
-
- Oct 26, 2005
-
-
Tom Lane authored
inFromCl true, meaning that they will list out as explicit RTEs if they are in a view or rule. Update comments about inFromCl to reflect the way it's now actually used. Per recent discussion.
-
- Oct 25, 2005
-
-
Tom Lane authored
for an outer join; symptom is bogus error "RIGHT JOIN is only supported with merge-joinable join conditions". Problem was that select_mergejoin_clauses did its tests in the wrong order. We need to force left join not right join for a merge join when there are non-mergeable join clauses; but the test for this only accounted for mergejoinability of the clause operator, and not whether the left and right Vars were of the proper relations. Per report from Jean-Pierre Pelletier.
-
Tom Lane authored
some small stylistic improvements in these functions. Also fix several places where TMODULO() was being used with wrong-sized quotient argument, creating a risk of overflow --- interval2tm was actually capable of going into an infinite loop because of this.
-
Tom Lane authored
to the main thread. This allows removal of WaitForSingleObjectEx() calls from the main thread, thereby allowing us to re-enable Qingqing Zhou's CHECK_FOR_INTERRUPTS performance improvement. Qingqing, Magnus, et al.
-
Bruce Momjian authored
-
- Oct 24, 2005
-
-
Bruce Momjian authored
PQregisterThreadLock(). I also remove the crypt() mention in the libpq threading section and added a single sentence in the client-auth manual page under crypt(). Crypt authentication is so old now that a separate paragraph about it seemed unwise. I also added a comment about our use of locking around pqGetpwuid().
-
Tom Lane authored
one CHECK_FOR_INTERRUPTS() call, so that you can control-C out of the loop. Reported by Merlin Moncure.
-
- Oct 22, 2005
-
-
Tom Lane authored
-
Tom Lane authored
WaitForSingleObjectEx is always called by CHECK_FOR_INTERRUPTS. This should be reinstated but the setitimer() emulation will have to be redesigned first.
-
Andrew Dunstan authored
minor code cleanup - replace useless struct timezone argument to gettimeofday with NULL in a few places, making it consistent with usage elsewhere.
-
- Oct 21, 2005
-
-
Tom Lane authored
a kernel call unless there's some evidence of a pending signal. This should bring its performance on Windows into line with the Unix version. Problem diagnosis and patch by Qingqing Zhou. Minor stylistic tweaks by moi ... if it's broken, it's my fault.
-
Tom Lane authored
properly advancing the CommandCounter between multiple sub-queries generated by rules, we forgot to update the snapshot being used, so that the successive sub-queries didn't actually see each others' results. This is still not *exactly* like the semantics of normal execution of the same queries, in that we don't take new transaction snapshots and hence don't see changes from concurrently committed commands, but I think that's OK and probably even preferable for EXPLAIN ANALYZE.
-
Tom Lane authored
of the form nextval('foo'::varchar) doesn't break. Per gripe from Jean-Pierre Pelletier. Initdb forced :-(
-
Tom Lane authored
-
Tom Lane authored
a parameter in binary format. Also, add a TIP explaining how to use casts in the query text to avoid needing to specify parameter types by OID. Also fix bogus spacing --- apparently somebody expanded the tabs in the example programs to 8 spaces instead of 4 when transposing them into SGML.
-
- Oct 20, 2005
-
-
Tom Lane authored
since it can take a fair amount of time and this can confuse boot scripts that expect postmaster.pid to appear quickly. Move initialization of SSL library and preloaded libraries to after that point, too, just for luck. Per reports from Tony Caduto and others.
-