Skip to content
Snippets Groups Projects
  1. May 08, 2010
    • Tom Lane's avatar
      Work around a subtle portability problem in use of printf %s format. · 54cd4f04
      Tom Lane authored
      Depending on which spec you read, field widths and precisions in %s may be
      counted either in bytes or characters.  Our code was assuming bytes, which
      is wrong at least for glibc's implementation, and in any case libc might
      have a different idea of the prevailing encoding than we do.  Hence, for
      portable results we must avoid using anything more complex than just "%s"
      unless the string to be printed is known to be all-ASCII.
      
      This patch fixes the cases I could find, including the psql formatting
      failure reported by Hernan Gonzalez.  In HEAD only, I also added comments
      to some places where it appears safe to continue using "%.*s".
      54cd4f04
  2. May 07, 2010
  3. May 06, 2010
  4. May 05, 2010
  5. May 03, 2010
  6. May 02, 2010
    • Simon Riggs's avatar
      Update standbycheck test output with new ERROR message changes. No changes · 3a0939ed
      Simon Riggs authored
      to tests and no changes in accepted server behaviour.
      3a0939ed
    • Simon Riggs's avatar
      Docs for standbycheck regression tests. · abeb17cd
      Simon Riggs authored
      abeb17cd
    • Simon Riggs's avatar
      Mention that max_standby_delay has units of milliseconds. Units are mentioned · 98bbab47
      Simon Riggs authored
      for all other parameters where the default is expressed in a different unit.
      98bbab47
    • Tom Lane's avatar
      Clean up some awkward, inaccurate, and inefficient processing around · f9ed327f
      Tom Lane authored
      MaxStandbyDelay.  Use the GUC units mechanism for the value, and choose more
      appropriate timestamp functions for performing tests with it.  Make the
      ps_activity manipulation in ResolveRecoveryConflictWithVirtualXIDs have
      behavior similar to ps_activity code elsewhere, notably not updating the
      display when update_process_title is off and not truncating the display
      contents at an arbitrarily-chosen length.  Improve the docs to be explicit
      about what MaxStandbyDelay actually measures, viz the difference between
      primary and standby servers' clocks, and the possible hazards if their clocks
      aren't in sync.
      f9ed327f
    • Tom Lane's avatar
      Add code to InternalIpcMemoryCreate() to handle the case where shmget() · 15416323
      Tom Lane authored
      returns EINVAL for an existing shared memory segment.  Although it's not
      terribly sensible, that behavior does meet the POSIX spec because EINVAL
      is the appropriate error code when the existing segment is smaller than the
      requested size, and the spec explicitly disclaims any particular ordering of
      error checks.  Moreover, it does in fact happen on OS X and probably other
      BSD-derived kernels.  (We were able to talk NetBSD into changing their code,
      but purging that behavior from the wild completely seems unlikely to happen.)
      We need to distinguish collision with a pre-existing segment from invalid size
      request in order to behave sensibly, so it's worth some extra code here to get
      it right.  Per report from Gavin Kistner and subsequent investigation.
      
      Back-patch to all supported versions, since any of them could get used
      with a kernel having the debatable behavior.
      15416323
  7. May 01, 2010
  8. Apr 30, 2010
  9. Apr 29, 2010
  10. Apr 28, 2010
Loading