Skip to content
Snippets Groups Projects
  1. Jul 13, 2010
  2. Jul 12, 2010
  3. Jul 10, 2010
    • Tom Lane's avatar
      Avoid an Assert failure in deconstruct_array() by making get_attstatsslot() · 5ce63f48
      Tom Lane authored
      use the actual element type of the array it's disassembling, rather than
      trusting the type OID passed in by its caller.  This is needed because
      sometimes the planner passes in a type OID that's only binary-compatible
      with the target column's type, rather than being an exact match.  Per an
      example from Bernd Helmle.
      
      Possibly we should refactor get_attstatsslot/free_attstatsslot to not expect
      the caller to supply type ID data at all, but for now I'll just do the
      minimum-change fix.
      
      Back-patch to 7.4.  Bernd's test case only crashes back to 8.0, but since
      these subroutines are the same in 7.4, I suspect there may be variant
      cases that would crash 7.4 as well.
      5ce63f48
  4. Jul 09, 2010
  5. Jul 08, 2010
  6. Jul 07, 2010
    • Tom Lane's avatar
      Adjust mbutils.c so it won't get broken by future pgindent runs. · 5b1b3ef7
      Tom Lane authored
      To do that, replace L'\0' by (WCHAR) 0.  Perhaps someday we should teach
      pgindent about wide-character literals, but so long as this is the only
      use-case in the entire Postgres sources, a workaround seems easier.
      5b1b3ef7
    • Robert Haas's avatar
      Make log_temp_files based on kB, and revert docs & comments to match. · 20be0d48
      Robert Haas authored
      Per extensive discussion on pgsql-hackers.  We are deliberately not
      back-patching this even though the behavior of 8.3 and 8.4 is
      unquestionably broken, for fear of breaking existing users of this
      parameter.  This incompatibility should be release-noted.
      20be0d48
    • Tom Lane's avatar
      Accept slightly grotty coding in Makefile.global in order to keep the -L · 458474d9
      Tom Lane authored
      flag for src/port/ in front of any -L flags placed in LDFLAGS by configure.
      This undoes an L-flag-ordering change that I had thought would be safe,
      but seems to be making at least one buildfarm member fail --- the only
      theory for orca's failure that I can think of is that it's got an old
      copy of libpgport.a in /usr/lib.  Also allow for LDFLAGS_SL to be set by
      contrib makefiles before they invoke Makefile.global.
      458474d9
  7. Jul 06, 2010
  8. Jul 05, 2010
    • Tom Lane's avatar
      Split the LDFLAGS make variable into two parts: LDFLAGS is now used for · 291a9577
      Tom Lane authored
      linking both executables and shared libraries, and we add on LDFLAGS_EX when
      linking executables or LDFLAGS_SL when linking shared libraries.  This
      provides a significantly cleaner way of dealing with link-time switches than
      the former behavior.  Also, make sure that the various platform-specific
      %.so: %.o rules incorporate LDFLAGS and LDFLAGS_SL; most of them missed that
      before.  (I did not add these variables for the platforms that invoke $(LD)
      directly, however.  It's not clear if we can do that safely, since for the
      most part we assume these variables use CC command-line syntax.)
      
      Per gripe from Aaron Swenson and subsequent investigation.
      291a9577
    • Heikki Linnakangas's avatar
      The previous fix in CVS HEAD and 8.4 for handling the case where a cursor · eb81b650
      Heikki Linnakangas authored
      being used in a PL/pgSQL FOR loop is closed was inadequate, as Tom Lane
      pointed out. The bug affects FOR statement variants too, because you can
      close an implicitly created cursor too by guessing the "<unnamed portal X>"
      name created for it.
      
      To fix that, "pin" the portal to prevent it from being dropped while it's
      being used in a PL/pgSQL FOR loop. Backpatch all the way to 7.4 which is
      the oldest supported version.
      eb81b650
  9. Jul 04, 2010
  10. Jul 03, 2010
    • Tom Lane's avatar
      Make vacuum_defer_cleanup_age be PGC_SIGHUP level, since it's not sensible · aceedd88
      Tom Lane authored
      to have different values in different processes of the primary server.
      Also put it into the "Streaming Replication" GUC category; it doesn't belong
      in "Standby Servers" because you use it on the master not the standby.
      In passing also correct guc.c's idea of wal_keep_segments' category.
      aceedd88
    • Tom Lane's avatar
      Replace max_standby_delay with two parameters, max_standby_archive_delay and · e76c1a0f
      Tom Lane authored
      max_standby_streaming_delay, and revise the implementation to avoid assuming
      that timestamps found in WAL records can meaningfully be compared to clock
      time on the standby server.  Instead, the delay limits are compared to the
      elapsed time since we last obtained a new WAL segment from archive or since
      we were last "caught up" to WAL data arriving via streaming replication.
      This avoids problems with clock skew between primary and standby, as well
      as other corner cases that the original coding would misbehave in, such
      as the primary server having significant idle time between transactions.
      Per my complaint some time ago and considerable ensuing discussion.
      
      Do some desultory editing on the hot standby documentation, too.
      e76c1a0f
    • Robert Haas's avatar
      Allow REASSIGNED OWNED to handle opclasses and opfamilies. · b3b7d603
      Robert Haas authored
      Backpatch to 8.3, which is as far back as we have opfamilies.
      The opclass portion could probably be backpatched to 8.2, when
      REASSIGN OWNED was added, but for now I have not done that.
      
      Asko Tiidumaa, with minor adjustments by me.
      b3b7d603
    • Andrew Dunstan's avatar
Loading