Skip to content
Snippets Groups Projects
  1. Sep 04, 2012
  2. Sep 03, 2012
    • Andrew Dunstan's avatar
      Fix bugs in exec.c that prevented pg_upgrade working in Windows. · c879e82b
      Andrew Dunstan authored
      Backpatch to 9.2 - code before that is quite different and should
      not have these defects.
      c879e82b
    • Tom Lane's avatar
      Back-patch recent pg_upgrade fixes into 9.2. · 5c7e91e9
      Tom Lane authored
      This syncs contrib/pg_upgrade in the 9.2 branch with HEAD, except for the
      HEAD changes related to converting XLogRecPtr to 64-bit int.  It includes
      back-patching these commits:
      
      666d494d
      pg_upgrade: abstract out copying of files from old cluster to new
      7afa8bed
      pg_upgrade: Run the created scripts in the test suite
      ab577e63
      Remove analyze_new_cluster.sh on make clean, too
      34c02044
      Fix thinko in comment
      088c065c
      pg_upgrade: Fix exec_prog API to be less flaky
      f763b771
      Fix pg_upgrade to cope with non-default unix_socket_directory scenarios.
      5c7e91e9
    • Tom Lane's avatar
      Make psql's \d+ show reloptions for all relkinds. · b681a874
      Tom Lane authored
      Formerly it would only show them for relkinds 'r' and 'f' (plain tables
      and foreign tables).  However, as of 9.2, views can also have reloptions,
      namely security_barrier.  The relkind restriction seems pointless and
      not at all future-proof, so just print reloptions whenever there are any.
      
      In passing, make some cosmetic improvements to the code that pulls the
      "tableinfo" fields out of the PGresult.
      
      Noted and patched by Dean Rasheed, with adjustment for all relkinds by me.
      b681a874
  3. Sep 01, 2012
    • Andrew Dunstan's avatar
      Restore setting of _USE_32BIT_TIME_T to 32 bit MSVC builds. · 2d038749
      Andrew Dunstan authored
      This was removed in commit cd004067,
      we're not quite sure why, but there have been reports of crashes due
      to AS Perl being built with it when we are not, and it certainly
      seems like the right thing to do. There is still some uncertainty
      as to why it sometimes fails and sometimes doesn't.
      
      Original patch from Owais Khani, substantially reworked and
      extended by Andrew Dunstan.
      2d038749
  4. Aug 31, 2012
    • Tom Lane's avatar
      Make configure probe for mbstowcs_l as well as wcstombs_l. · e4679442
      Tom Lane authored
      We previously supposed that any given platform would supply both or neither
      of these functions, so that one configure test would be sufficient.  It now
      appears that at least on AIX this is not the case ... which is likely an
      AIX bug, but nonetheless we need to cope with it.  So use separate tests.
      Per bug #6758; thanks to Andrew Hastie for doing the followup testing
      needed to confirm what was happening.
      
      Backpatch to 9.1, where we began using these functions.
      e4679442
    • Tom Lane's avatar
      Back-patch recent fixes for gistchoose and gistRelocateBuildBuffersOnSplit. · d2528e5d
      Tom Lane authored
      This back-ports commits c8ba697a and
      e5db11c5, which fix one definite and one
      speculative bug in gistchoose, and make the code a lot more intelligible as
      well.  In 9.2 only, this also affects the largely-copied-and-pasted logic
      in gistRelocateBuildBuffersOnSplit.
      
      The impact of the bugs was that the functions might make poor decisions
      as to which index tree branch to push a new entry down into, resulting in
      GiST index bloat and poor performance.  The fixes rectify these decisions
      for future insertions, but a REINDEX would be needed to clean up any
      existing index bloat.
      
      Alexander Korotkov, Robert Haas, Tom Lane
      d2528e5d
  5. Aug 30, 2012
  6. Aug 28, 2012
  7. Aug 27, 2012
    • Tom Lane's avatar
      Fix DROP INDEX CONCURRENTLY IF EXISTS. · a6f43529
      Tom Lane authored
      This threw ERROR, not the expected NOTICE, if the index didn't exist.
      The bug was actually visible in not-as-expected regression test output,
      so somebody wasn't paying too close attention in commit
      8cb53654.
      Per report from Brendan Byrd.
      a6f43529
    • Peter Eisentraut's avatar
      pg_basebackup: Correct error message · 81bcc8bc
      Peter Eisentraut authored
      It still thought that the --xlog-method option argument could be
      empty, as in a previous version of this feature.
      81bcc8bc
  8. Aug 25, 2012
  9. Aug 24, 2012
    • Tom Lane's avatar
      Fix issues with checks for unsupported transaction states in Hot Standby. · c3ca786d
      Tom Lane authored
      The GUC check hooks for transaction_read_only and transaction_isolation
      tried to check RecoveryInProgress(), so as to disallow setting read/write
      mode or serializable isolation level (respectively) in hot standby
      sessions.  However, GUC check hooks can be called in many situations where
      we're not connected to shared memory at all, resulting in a crash in
      RecoveryInProgress().  Among other cases, this results in EXEC_BACKEND
      builds crashing during child process start if default_transaction_isolation
      is serializable, as reported by Heikki Linnakangas.  Protect those calls
      by silently allowing any setting when not inside a transaction; which is
      okay anyway since these GUCs are always reset at start of transaction.
      
      Also, add a check to GetSerializableTransactionSnapshot() to complain
      if we are in hot standby.  We need that check despite the one in
      check_XactIsoLevel() because default_transaction_isolation could be
      serializable.  We don't want to complain any sooner than this in such
      cases, since that would prevent running transactions at all in such a
      state; but a transaction can be run, if SET TRANSACTION ISOLATION is done
      before setting a snapshot.  Per report some months ago from Robert Haas.
      
      Back-patch to 9.1, since these problems were introduced by the SSI patch.
      
      Kevin Grittner and Tom Lane, with ideas from Heikki Linnakangas
      c3ca786d
    • Peter Eisentraut's avatar
    • Peter Eisentraut's avatar
      libpq: Fix memory leak in URI parser · 1c8c084c
      Peter Eisentraut authored
      When an invalid query parameter is reported, some memory leaks.
      
      found by Coverity
      1c8c084c
    • Peter Eisentraut's avatar
      Translation updates · f3df4cd2
      Peter Eisentraut authored
      f3df4cd2
    • Tom Lane's avatar
      Stamp 9.2rc1. · e8c736ca
      Tom Lane authored
  10. Aug 23, 2012
    • Tom Lane's avatar
      Fix cascading privilege revoke to notice when privileges are still held. · fb7b6197
      Tom Lane authored
      If we revoke a grant option from some role X, but X still holds the option
      via another grant, we should not recursively revoke the privilege from
      role(s) Y that X had granted it to.  This was supposedly fixed as one
      aspect of commit 4b2dafcc, but I must not
      have tested it, because in fact that code never worked: it forgot to shift
      the grant-option bits back over when masking the bits being revoked.
      
      Per bug #6728 from Daniel German.  Back-patch to all active branches,
      since this has been wrong since 8.0.
      fb7b6197
    • Heikki Linnakangas's avatar
      Fix typo in example. · ebcc0158
      Heikki Linnakangas authored
      ebcc0158
    • Tom Lane's avatar
      Remove overly-pessimistic statement about constraint exclusion. · ead31d1a
      Tom Lane authored
      As of 9.2, constraint exclusion should work okay with prepared statements:
      the planner will try custom plans with actual values of the parameters,
      and observe that they are a lot cheaper than the generic plan, and thus
      never fall back to using the generic plan.  Noted by Tatsuhito Kasahara.
      ead31d1a
  11. Aug 22, 2012
  12. Aug 21, 2012
    • Tom Lane's avatar
      Fix dumping of security_barrier views with circular dependencies. · 1ace7868
      Tom Lane authored
      If a view has circular dependencies, pg_dump splits it into a CREATE TABLE
      and a CREATE RULE command to break the dependency loop.  However, if the
      view has reloptions, those options cannot be applied in the CREATE TABLE
      command, because views and tables have different allowed reloptions so
      CREATE TABLE would reject them.  Instead apply the reloptions after the
      CREATE RULE, using ALTER VIEW SET.
      1ace7868
  13. Aug 20, 2012
  14. Aug 17, 2012
    • Tom Lane's avatar
      Check LIBXML_VERSION instead of testing in configure script. · 33f40976
      Tom Lane authored
      We had put a test for libxml2's xmlStructuredErrorContext variable in
      configure, but of course that doesn't work on Windows builds.  The next
      best alternative seems to be to test the LIBXML_VERSION symbol provided
      by xmlversion.h.
      
      Per report from Talha Bin Rizwan, though this fixes it in a different way
      than his proposed patch.
      33f40976
  15. Aug 16, 2012
    • Tom Lane's avatar
      Allow create_index_paths() to consider multiple join bitmapscan paths. · 26893906
      Tom Lane authored
      In the initial cut at the "parameterized paths" feature, I'd simplified
      create_index_paths() to the point where it would only generate a single
      parameterized bitmap path per relation.  Experimentation with an example
      supplied by Josh Berkus convinces me that that's not good enough: we really
      need to consider a bitmap path for each possible outer relation.  Otherwise
      we have regressions relative to pre-9.2 versions, in which the planner
      picks a plain indexscan where it should have used a bitmap scan in queries
      involving three or more tables.  Indeed, after fixing this, several queries
      in the regression tests show improved plans as a result of using bitmap not
      plain indexscans.
      26893906
Loading