picksplit algorithm for Rtree. Please apply patch below to CVS

Oleg Bartunov

  everywhere.

At least it was now detected correctly.

marko

  produces garbage.

I learned the hard way that

        #if UNDEFINED_1 == UNDEFINED_2
        #error "gcc is idiot"
        #endif

prints "gcc is idiot" ...

Affected are MD5/SHA1 in internal library, and also HMAC-MD5/HMAC-SHA1/
crypt-md5 which use them.  Blowfish is ok, also Rijndael on at
least x86.

Big thanks to Daniel Holtzman who send me a build log which
contained warning:

        md5.c:246: warning: `X' defined but not used

Yes, gcc is that helpful...

Please apply this.

--
marko

Thanks.

Teodor Sigaev

No change in results of script, but perhaps less confusion for people
reading it.

needs it.

Seems it is getting compileable...

Marko Kreen

should be all.

Marko Kreen

failures on FreeBSD.  This patch replaces uint -> unsigned.

This was reported by Daniel Holtzman against 0.4pre3 standalone
package, but it needs fixing in contrib/pgcrypto too.

Marko Kreen

and comment in src/backend/parser/Makefile for the technical details.

andrea gelmini

memory.  This fixes it.  Also a free() was missing.

marko

initdb/regression tests pass.

spacing.  Also adds space for one-line comments.

tests pass.

these macros fail in if/else cases:

#define X \
{ \
	... \
}


{

	if (...)
		X;
	else
		...
}

with proper setup:

#define X \
do { \
	... \
} while (0)

it works fine.

the entered password would get echoed on some platforms, eg HPUX.
We have enough copies of this code that I'm thinking it ought to be
moved into libpq, but that's a task for another day.

From Oleg Bartunov and Teodor Sigaev.

Oleg Bartunov

datatype in test, to try to avoid any dependency on local time zone.

build on systems without.

* minor doc updates

Marko Kreen

 1. gist__int_ops is now without lossy
 2. added sort entry in picksplit

Oleg Bartunov

Marko Kreen

Converted pgcrypto one too.

* Changed default randomness source to libc random()
  That way pgcrypto does not have any external dependencies
  and should work everywhere.
* Re-enabled pgcrypto build in contrib/makefile
* contrib/README update - there is more stuff than
  only 'hash functions'
* Noted the libc random fact in README.pgcrypto


Marko Kreen