Skip to content
Snippets Groups Projects
  1. Jan 03, 2017
  2. Jan 02, 2016
  3. Jan 06, 2015
  4. Aug 25, 2014
  5. Jul 14, 2014
  6. Apr 18, 2014
    • Peter Eisentraut's avatar
      Create function prototype as part of PG_FUNCTION_INFO_V1 macro · e7128e8d
      Peter Eisentraut authored
      Because of gcc -Wmissing-prototypes, all functions in dynamically
      loadable modules must have a separate prototype declaration.  This is
      meant to detect global functions that are not declared in header files,
      but in cases where the function is called via dfmgr, this is redundant.
      Besides filling up space with boilerplate, this is a frequent source of
      compiler warnings in extension modules.
      
      We can fix that by creating the function prototype as part of the
      PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway.  That
      makes the code of modules cleaner, because there is one less place where
      the entry points have to be listed, and creates an additional check that
      functions have the right prototype.
      
      Remove now redundant prototypes from contrib and other modules.
      e7128e8d
  7. Jan 07, 2014
  8. Jan 01, 2013
  9. Jan 02, 2012
  10. Nov 04, 2011
    • Tom Lane's avatar
      Fix bogus code in contrib/ tsearch dictionary examples. · e3e3087d
      Tom Lane authored
      Both dict_int and dict_xsyn were blithely assuming that whatever memory
      palloc gives back will be pre-zeroed.  This would typically work for
      just about long enough to run their regression tests, and no longer :-(.
      
      The pre-9.0 code in dict_xsyn was even lamer than that, as it would
      happily give back a pointer to the result of palloc(0), encouraging
      its caller to access off the end of memory.  Again, this would just
      barely fail to fail as long as memory contained nothing but zeroes.
      
      Per a report from Rodrigo Hjort that code based on these examples
      didn't work reliably.
      e3e3087d
  11. Oct 12, 2011
    • Tom Lane's avatar
      Throw a useful error message if an extension script file is fed to psql. · 458857cc
      Tom Lane authored
      We have seen one too many reports of people trying to use 9.1 extension
      files in the old-fashioned way of sourcing them in psql.  Not only does
      that usually not work (due to failure to substitute for MODULE_PATHNAME
      and/or @extschema@), but if it did work they'd get a collection of loose
      objects not an extension.  To prevent this, insert an \echo ... \quit
      line that prints a suitable error message into each extension script file,
      and teach commands/extension.c to ignore lines starting with \echo.
      That should not only prevent any adverse consequences of loading a script
      file the wrong way, but make it crystal clear to users that they need to
      do it differently now.
      
      Tom Lane, following an idea of Andrew Dunstan's.  Back-patch into 9.1
      ... there is not going to be much value in this if we wait till 9.2.
      458857cc
  12. Sep 11, 2011
    • Peter Eisentraut's avatar
      Remove many -Wcast-qual warnings · 1b81c2fe
      Peter Eisentraut authored
      This addresses only those cases that are easy to fix by adding or
      moving a const qualifier or removing an unnecessary cast.  There are
      many more complicated cases remaining.
      1b81c2fe
  13. Sep 01, 2011
  14. Apr 25, 2011
    • Peter Eisentraut's avatar
      Support "make check" in contrib · f8ebe3bc
      Peter Eisentraut authored
      Added a new option --extra-install to pg_regress to arrange installing
      the respective contrib directory into the temporary installation.
      This is currently not yet supported for Windows MSVC builds.
      
      Updated the .gitignore files for contrib modules to ignore the
      leftovers of a temp-install check run.
      
      Changed the exit status of "make check" in a pgxs build (which still
      does nothing) to 0 from 1.
      
      Added "make check" in contrib to top-level "make check-world".
      f8ebe3bc
  15. Feb 14, 2011
    • Tom Lane's avatar
      Avoid use of CREATE OR REPLACE FUNCTION in extension installation files. · 029fac22
      Tom Lane authored
      It was never terribly consistent to use OR REPLACE (because of the lack of
      comparable functionality for data types, operators, etc), and
      experimentation shows that it's now positively pernicious in the extension
      world.  We really want a failure to occur if there are any conflicts, else
      it's unclear what the extension-ownership state of the conflicted object
      ought to be.  Most of the time, CREATE EXTENSION will fail anyway because
      of conflicts on other object types, but an extension defining only
      functions can succeed, with bad results.
      029fac22
    • Tom Lane's avatar
      Convert contrib modules to use the extension facility. · 629b3af2
      Tom Lane authored
      This isn't fully tested as yet, in particular I'm not sure that the
      "foo--unpackaged--1.0.sql" scripts are OK.  But it's time to get some
      buildfarm cycles on it.
      
      sepgsql is not converted to an extension, mainly because it seems to
      require a very nonstandard installation process.
      
      Dimitri Fontaine and Tom Lane
      629b3af2
  16. Jan 01, 2011
  17. Sep 22, 2010
  18. Sep 20, 2010
  19. Feb 26, 2010
  20. Jan 02, 2010
  21. Aug 05, 2009
  22. Jan 01, 2009
  23. Jun 18, 2008
    • Tom Lane's avatar
      Improve error reporting for problems in text search configuration files · fbeb9da2
      Tom Lane authored
      by installing an error context subroutine that will provide the file name
      and line number for all errors detected while reading a config file.
      Some of the reader routines were already doing that in an ad-hoc way for
      errors detected directly in the reader, but it didn't help for problems
      detected in subroutines, such as encoding violations.
      
      Back-patch to 8.3 because 8.3 is where people will be trying to debug
      configuration files.
      fbeb9da2
  24. Jan 01, 2008
  25. Dec 02, 2007
  26. Nov 15, 2007
  27. Nov 13, 2007
  28. Nov 11, 2007
    • Bruce Momjian's avatar
      Make /contrib install/uninstall script consistent: · 926bbab4
      Bruce Momjian authored
      	remove transactions
      	use create or replace function
      	make formatting consistent
      	set search patch on first line
      
      Add documentation on modifying *.sql to set the search patch, and
      mention that major upgrades should still run the installation scripts.
      
      Some of these issues were spotted by Tom today.
      926bbab4
  29. Oct 16, 2007
  30. Oct 15, 2007
Loading