Skip to content
Snippets Groups Projects
Commit d951d606 authored by Tom Lane's avatar Tom Lane
Browse files

Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit.  For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime.  Use the standard doubling approach instead.

This is a longstanding performance bug, so back-patch to all active
branches.

Neil Conway
parent dadef8af
No related branches found
No related tags found
No related merge requests found
...@@ -1674,7 +1674,8 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self) ...@@ -1674,7 +1674,8 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self)
if (tuptable->free == 0) if (tuptable->free == 0)
{ {
tuptable->free = 256; /* Double the size of the pointer array */
tuptable->free = tuptable->alloced;
tuptable->alloced += tuptable->free; tuptable->alloced += tuptable->free;
tuptable->vals = (HeapTuple *) repalloc(tuptable->vals, tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,
tuptable->alloced * sizeof(HeapTuple)); tuptable->alloced * sizeof(HeapTuple));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment