-
- Downloads
Use wrappers of PG_DETOAST_DATUM_PACKED() more.
This makes almost all core code follow the policy introduced in the previous commit. Specific decisions: - Text search support functions with char* and length arguments, such as prsstart and lexize, may receive unaligned strings. I doubt maintainers of non-core text search code will notice. - Use plain VARDATA() on values detoasted or synthesized earlier in the same function. Use VARDATA_ANY() on varlenas sourced outside the function, even if they happen to always have four-byte headers. As an exception, retain the universal practice of using VARDATA() on return values of SendFunctionCall(). - Retain PG_GETARG_BYTEA_P() in pageinspect. (Page images are too large for a one-byte header, so this misses no optimization.) Sites that do not call get_page_from_raw() typically need the four-byte alignment. - For now, do not change btree_gist. Its use of four-byte headers in memory is partly entangled with storage of 4-byte headers inside GBT_VARKEY, on disk. - For now, do not change gtrgm_consistent() or gtrgm_distance(). They incorporate the varlena header into a cache, and there are multiple credible implementation strategies to consider.
Showing
- contrib/adminpack/adminpack.c 8 additions, 8 deletionscontrib/adminpack/adminpack.c
- contrib/dblink/dblink.c 5 additions, 5 deletionscontrib/dblink/dblink.c
- contrib/fuzzystrmatch/dmetaphone.c 2 additions, 2 deletionscontrib/fuzzystrmatch/dmetaphone.c
- contrib/fuzzystrmatch/fuzzystrmatch.c 3 additions, 3 deletionscontrib/fuzzystrmatch/fuzzystrmatch.c
- contrib/intarray/_int_op.c 3 additions, 3 deletionscontrib/intarray/_int_op.c
- contrib/pageinspect/btreefuncs.c 3 additions, 3 deletionscontrib/pageinspect/btreefuncs.c
- contrib/pageinspect/rawpage.c 5 additions, 5 deletionscontrib/pageinspect/rawpage.c
- contrib/pg_prewarm/pg_prewarm.c 2 additions, 2 deletionscontrib/pg_prewarm/pg_prewarm.c
- contrib/pg_trgm/trgm_gin.c 8 additions, 7 deletionscontrib/pg_trgm/trgm_gin.c
- contrib/pg_trgm/trgm_gist.c 9 additions, 8 deletionscontrib/pg_trgm/trgm_gist.c
- contrib/pg_trgm/trgm_op.c 6 additions, 6 deletionscontrib/pg_trgm/trgm_op.c
- contrib/pgcrypto/pgcrypto.c 47 additions, 47 deletionscontrib/pgcrypto/pgcrypto.c
- contrib/pgcrypto/pgp-pgsql.c 50 additions, 50 deletionscontrib/pgcrypto/pgp-pgsql.c
- contrib/pgrowlocks/pgrowlocks.c 1 addition, 1 deletioncontrib/pgrowlocks/pgrowlocks.c
- contrib/pgstattuple/pgstatindex.c 4 additions, 4 deletionscontrib/pgstattuple/pgstatindex.c
- contrib/pgstattuple/pgstattuple.c 2 additions, 2 deletionscontrib/pgstattuple/pgstattuple.c
- contrib/sepgsql/label.c 2 additions, 2 deletionscontrib/sepgsql/label.c
- contrib/spi/autoinc.c 1 addition, 1 deletioncontrib/spi/autoinc.c
- contrib/sslinfo/sslinfo.c 2 additions, 2 deletionscontrib/sslinfo/sslinfo.c
- contrib/unaccent/unaccent.c 3 additions, 3 deletionscontrib/unaccent/unaccent.c
Loading
Please register or sign in to comment