Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

conversioncmds.c

  • Tom Lane's avatar
    0d79c0a8
    Make various variables const (read-only). · 0d79c0a8
    Tom Lane authored
    These changes should generally improve correctness/maintainability.
    A nice side benefit is that several kilobytes move from initialized
    data to text segment, allowing them to be shared across processes and
    probably reducing copy-on-write overhead while forking a new backend.
    Unfortunately this doesn't seem to help libpq in the same way (at least
    not when it's compiled with -fpic on x86_64), but we can hope the linker
    at least collects all nominally-const data together even if it's not
    actually part of the text segment.
    
    Also, make pg_encname_tbl[] static in encnames.c, since there seems
    no very good reason for any other code to use it; per a suggestion
    from Wim Lewis, who independently submitted a patch that was mostly
    a subset of this one.
    
    Oskari Saarenmaa, with some editorialization by me
    0d79c0a8
    History
    Make various variables const (read-only).
    Tom Lane authored
    These changes should generally improve correctness/maintainability.
    A nice side benefit is that several kilobytes move from initialized
    data to text segment, allowing them to be shared across processes and
    probably reducing copy-on-write overhead while forking a new backend.
    Unfortunately this doesn't seem to help libpq in the same way (at least
    not when it's compiled with -fpic on x86_64), but we can hope the linker
    at least collects all nominally-const data together even if it's not
    actually part of the text segment.
    
    Also, make pg_encname_tbl[] static in encnames.c, since there seems
    no very good reason for any other code to use it; per a suggestion
    from Wim Lewis, who independently submitted a patch that was mostly
    a subset of this one.
    
    Oskari Saarenmaa, with some editorialization by me