-
- Downloads
Make various variables const (read-only).
These changes should generally improve correctness/maintainability. A nice side benefit is that several kilobytes move from initialized data to text segment, allowing them to be shared across processes and probably reducing copy-on-write overhead while forking a new backend. Unfortunately this doesn't seem to help libpq in the same way (at least not when it's compiled with -fpic on x86_64), but we can hope the linker at least collects all nominally-const data together even if it's not actually part of the text segment. Also, make pg_encname_tbl[] static in encnames.c, since there seems no very good reason for any other code to use it; per a suggestion from Wim Lewis, who independently submitted a patch that was mostly a subset of this one. Oskari Saarenmaa, with some editorialization by me
Showing
- src/backend/catalog/objectaddress.c 14 additions, 14 deletionssrc/backend/catalog/objectaddress.c
- src/backend/commands/conversioncmds.c 1 addition, 1 deletionsrc/backend/commands/conversioncmds.c
- src/backend/regex/regc_lex.c 2 additions, 2 deletionssrc/backend/regex/regc_lex.c
- src/backend/regex/regcomp.c 1 addition, 1 deletionsrc/backend/regex/regcomp.c
- src/backend/regex/regerror.c 3 additions, 3 deletionssrc/backend/regex/regerror.c
- src/backend/tsearch/wparser_def.c 2 additions, 2 deletionssrc/backend/tsearch/wparser_def.c
- src/backend/utils/adt/datetime.c 3 additions, 3 deletionssrc/backend/utils/adt/datetime.c
- src/backend/utils/adt/formatting.c 30 additions, 37 deletionssrc/backend/utils/adt/formatting.c
- src/backend/utils/adt/tsrank.c 8 additions, 8 deletionssrc/backend/utils/adt/tsrank.c
- src/backend/utils/mb/encnames.c 21 additions, 34 deletionssrc/backend/utils/mb/encnames.c
- src/backend/utils/mb/mbutils.c 3 additions, 3 deletionssrc/backend/utils/mb/mbutils.c
- src/backend/utils/mb/wchar.c 1 addition, 1 deletionsrc/backend/utils/mb/wchar.c
- src/common/relpath.c 1 addition, 1 deletionsrc/common/relpath.c
- src/include/common/relpath.h 2 additions, 1 deletionsrc/include/common/relpath.h
- src/include/mb/pg_wchar.h 7 additions, 19 deletionssrc/include/mb/pg_wchar.h
- src/include/utils/datetime.h 2 additions, 0 deletionssrc/include/utils/datetime.h
Loading
Please register or sign in to comment