Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

explain.c

  • Tom Lane's avatar
    0b337904
    Clean up the mess around EXPLAIN and materialized views. · 0b337904
    Tom Lane authored
    Revert the matview-related changes in explain.c's API, as per recent
    complaint from Robert Haas.  The reason for these appears to have been
    principally some ill-considered choices around having intorel_startup do
    what ought to be parse-time checking, plus a poor arrangement for passing
    it the view parsetree it needs to store into pg_rewrite when creating a
    materialized view.  Do the latter by having parse analysis stick a copy
    into the IntoClause, instead of doing it at runtime.  (On the whole,
    I seriously question the choice to represent CREATE MATERIALIZED VIEW as a
    variant of SELECT INTO/CREATE TABLE AS, because that means injecting even
    more complexity into what was already a horrid legacy kluge.  However,
    I didn't go so far as to rethink that choice ... yet.)
    
    I also moved several error checks into matview parse analysis, and
    made the check for external Params in a matview more accurate.
    
    In passing, clean things up a bit more around interpretOidsOption(),
    and fix things so that we can use that to force no-oids for views,
    sequences, etc, thereby eliminating the need to cons up "oids = false"
    options when creating them.
    
    catversion bump due to change in IntoClause.  (I wonder though if we
    really need readfuncs/outfuncs support for IntoClause anymore.)
    0b337904
    History
    Clean up the mess around EXPLAIN and materialized views.
    Tom Lane authored
    Revert the matview-related changes in explain.c's API, as per recent
    complaint from Robert Haas.  The reason for these appears to have been
    principally some ill-considered choices around having intorel_startup do
    what ought to be parse-time checking, plus a poor arrangement for passing
    it the view parsetree it needs to store into pg_rewrite when creating a
    materialized view.  Do the latter by having parse analysis stick a copy
    into the IntoClause, instead of doing it at runtime.  (On the whole,
    I seriously question the choice to represent CREATE MATERIALIZED VIEW as a
    variant of SELECT INTO/CREATE TABLE AS, because that means injecting even
    more complexity into what was already a horrid legacy kluge.  However,
    I didn't go so far as to rethink that choice ... yet.)
    
    I also moved several error checks into matview parse analysis, and
    made the check for external Params in a matview more accurate.
    
    In passing, clean things up a bit more around interpretOidsOption(),
    and fix things so that we can use that to force no-oids for views,
    sequences, etc, thereby eliminating the need to cons up "oids = false"
    options when creating them.
    
    catversion bump due to change in IntoClause.  (I wonder though if we
    really need readfuncs/outfuncs support for IntoClause anymore.)