-
- Downloads
Clean up the mess around EXPLAIN and materialized views.
Revert the matview-related changes in explain.c's API, as per recent complaint from Robert Haas. The reason for these appears to have been principally some ill-considered choices around having intorel_startup do what ought to be parse-time checking, plus a poor arrangement for passing it the view parsetree it needs to store into pg_rewrite when creating a materialized view. Do the latter by having parse analysis stick a copy into the IntoClause, instead of doing it at runtime. (On the whole, I seriously question the choice to represent CREATE MATERIALIZED VIEW as a variant of SELECT INTO/CREATE TABLE AS, because that means injecting even more complexity into what was already a horrid legacy kluge. However, I didn't go so far as to rethink that choice ... yet.) I also moved several error checks into matview parse analysis, and made the check for external Params in a matview more accurate. In passing, clean things up a bit more around interpretOidsOption(), and fix things so that we can use that to force no-oids for views, sequences, etc, thereby eliminating the need to cons up "oids = false" options when creating them. catversion bump due to change in IntoClause. (I wonder though if we really need readfuncs/outfuncs support for IntoClause anymore.)
Showing
- src/backend/commands/createas.c 43 additions, 99 deletionssrc/backend/commands/createas.c
- src/backend/commands/explain.c 21 additions, 16 deletionssrc/backend/commands/explain.c
- src/backend/commands/prepare.c 1 addition, 1 deletionsrc/backend/commands/prepare.c
- src/backend/commands/sequence.c 1 addition, 1 deletionsrc/backend/commands/sequence.c
- src/backend/commands/tablecmds.c 3 additions, 51 deletionssrc/backend/commands/tablecmds.c
- src/backend/commands/typecmds.c 1 addition, 1 deletionsrc/backend/commands/typecmds.c
- src/backend/commands/view.c 0 additions, 1 deletionsrc/backend/commands/view.c
- src/backend/nodes/copyfuncs.c 1 addition, 1 deletionsrc/backend/nodes/copyfuncs.c
- src/backend/nodes/equalfuncs.c 1 addition, 1 deletionsrc/backend/nodes/equalfuncs.c
- src/backend/nodes/nodeFuncs.c 3 additions, 0 deletionssrc/backend/nodes/nodeFuncs.c
- src/backend/nodes/outfuncs.c 1 addition, 1 deletionsrc/backend/nodes/outfuncs.c
- src/backend/nodes/readfuncs.c 1 addition, 1 deletionsrc/backend/nodes/readfuncs.c
- src/backend/parser/analyze.c 44 additions, 18 deletionssrc/backend/parser/analyze.c
- src/backend/parser/gram.y 3 additions, 10 deletionssrc/backend/parser/gram.y
- src/backend/parser/parse_clause.c 9 additions, 9 deletionssrc/backend/parser/parse_clause.c
- src/backend/parser/parse_param.c 36 additions, 0 deletionssrc/backend/parser/parse_param.c
- src/backend/parser/parse_relation.c 49 additions, 0 deletionssrc/backend/parser/parse_relation.c
- src/backend/parser/parse_utilcmd.c 1 addition, 3 deletionssrc/backend/parser/parse_utilcmd.c
- src/include/catalog/catversion.h 1 addition, 1 deletionsrc/include/catalog/catversion.h
- src/include/commands/createas.h 0 additions, 4 deletionssrc/include/commands/createas.h
Loading
Please register or sign in to comment