Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

utils

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Tom Lane authored
    Back-patch commit dddfc4cb, which broke LDFLAGS and related Makefile
    variables into two parts, one for within-build-tree library references and
    one for external libraries, to ensure that the order of -L flags has all
    of the former before all of the latter.  This turns out to fix a problem
    recently noted on buildfarm member peripatus, that we attempted to
    incorporate code from libpgport.a into a shared library.  That will fail on
    platforms that are sticky about putting non-PIC code into shared libraries.
    (It's quite surprising we hadn't seen such failures before, since the code
    in question has been like that for a long time.)
    
    I think that peripatus' problem could have been fixed with just a subset
    of this patch; but since the previous issue of accidentally linking to the
    wrong copy of a Postgres shlib seems likely to bite people in the field,
    let's just back-patch the whole change.  Now that commit dddfc4cb has
    survived some beta testing, I'm less afraid to back-patch it than I was
    at the time.
    
    This also fixes undesired inclusion of "-DFRONTEND" in pg_config's CPPFLAGS
    output (in 9.6 and up) and undesired inclusion of "-L../../src/common" in
    its LDFLAGS output (in all supported branches).
    
    Back-patch to v10 and older branches; this is already in v11.
    
    Discussion: https://postgr.es/m/20180704234304.bq2dxispefl65odz@ler-imac.local
    ccc286da
    History
    Name Last commit Last update
    ..