Skip to content
Snippets Groups Projects
  1. Feb 23, 2011
    • Tom Lane's avatar
      Add a relkind field to RangeTblEntry to avoid some syscache lookups. · bdca82f4
      Tom Lane authored
      The recent additions for FDW support required checking foreign-table-ness
      in several places in the parse/plan chain.  While it's not clear whether
      that would really result in a noticeable slowdown, it seems best to avoid
      any performance risk by keeping a copy of the relation's relkind in
      RangeTblEntry.  That might have some other uses later, anyway.
      Per discussion.
      bdca82f4
  2. Feb 22, 2011
    • Peter Eisentraut's avatar
      Add PL/Python functions for quoting strings · 1c51c7d5
      Peter Eisentraut authored
      Add functions plpy.quote_ident, plpy.quote_literal,
      plpy.quote_nullable, which wrap the equivalent SQL functions.
      
      To be able to propagate char * constness properly, make the argument
      of quote_literal_cstr() const char *.  This also makes it more
      consistent with quote_identifier().
      
      Jan Urbański, reviewed by Hitoshi Harada, some refinements by Peter
      Eisentraut
      1c51c7d5
    • Robert Haas's avatar
      Fix a couple of unlogged tables goofs. · 3e6b305d
      Robert Haas authored
      "SELECT ... INTO UNLOGGED tabname" works, but wasn't documented; CREATE
      UNLOGGED SEQUENCE and CREATE UNLOGGED VIEW failed an assertion, instead
      of throwing a sensible error.
      
      Latter issue reported by Itagaki Takahiro; patch review by Tom Lane.
      3e6b305d
    • Tom Lane's avatar
      Allow binary I/O of type "void". · 1ab9b012
      Tom Lane authored
      void_send is useful for the same reason that void_out doesn't throw error,
      namely that someone might do "select void_returning_func(...)"  from a
      client that prefers to operate in binary mode.  The void_recv function may
      or may not have any practical use, but we provide it for symmetry.
      
      Radosław Smogura
      1ab9b012
    • Bruce Momjian's avatar
    • Tom Lane's avatar
      Remove ExecRemoveJunk(), which is no longer used anywhere. · 2e852e54
      Tom Lane authored
      This was a leftover from the pre-8.1 design of junkfilters.  It doesn't
      seem to have any reason to live, since it's merely a combination of two
      easy function calls, and not a well-designed combination at that (it
      encourages callers to leak the result tuple).
      2e852e54
    • Tom Lane's avatar
      Fix dangling-pointer problem in before-row update trigger processing. · a210be77
      Tom Lane authored
      ExecUpdate checked for whether ExecBRUpdateTriggers had returned a new
      tuple value by seeing if the returned tuple was pointer-equal to the old
      one.  But the "old one" was in estate->es_junkFilter's result slot, which
      would be scribbled on if we had done an EvalPlanQual update in response to
      a concurrent update of the target tuple; therefore we were comparing a
      dangling pointer to a live one.  Given the right set of circumstances we
      could get a false match, resulting in not forcing the tuple to be stored in
      the slot we thought it was stored in.  In the case reported by Maxim Boguk
      in bug #5798, this led to "cannot extract system attribute from virtual
      tuple" failures when trying to do "RETURNING ctid".  I believe there is a
      very-low-probability chance of more serious errors, such as generating
      incorrect index entries based on the original rather than the
      trigger-modified version of the row.
      
      In HEAD, change all of ExecBRInsertTriggers, ExecIRInsertTriggers,
      ExecBRUpdateTriggers, and ExecIRUpdateTriggers so that they continue to
      have similar APIs.  In the back branches I just changed
      ExecBRUpdateTriggers, since there is no bug in the ExecBRInsertTriggers
      case.
      a210be77
    • Bruce Momjian's avatar
      Move information_schema duplicate constraint note to the top of the · fee78027
      Bruce Momjian authored
      information schema documentation because it affects several tables.
      fee78027
  3. Feb 21, 2011
  4. Feb 20, 2011
  5. Feb 19, 2011
  6. Feb 18, 2011
  7. Feb 17, 2011
Loading