Skip to content
Snippets Groups Projects
  1. Mar 02, 2006
    • Tom Lane's avatar
      Repair oidvectorrecv and int2vectorrecv, which I broke while changing · 9356877b
      Tom Lane authored
      them to use array_recv :-(.  Per report from Tim Kordas.
      9356877b
    • Tom Lane's avatar
      Fix possible crash at transaction end when a plpgsql function is used and · fa7f6ff0
      Tom Lane authored
      then modified within the same transaction.  The code was using a linked list
      of active PLpgSQL_expr structs, which was OK when it was written because
      plpgsql never released any parse data structures for the life of the backend.
      But since Neil fixed plpgsql's memory management, elements of the linked list
      could be freed, leading to crash when the list is chased.  Per report and test
      case from Kris Jurka.
      fa7f6ff0
    • Tom Lane's avatar
      Fix up pg_dump to emit shell-type definitions at the proper time, to · 181f55e5
      Tom Lane authored
      make use of the recently added ability to create a shell type explicitly.
      
      I also put in place some infrastructure to allow dump/no dump decisions
      to be made separately for each database object, rather than the former
      hardwired 'dump if in a dumpable schema' policy.  This was needed anyway
      for shell types so now seemed a convenient time to do it.  The flexibility
      isn't exposed to the user yet, but is ready for future extensions.
      181f55e5
  2. Mar 01, 2006
    • Neil Conway's avatar
      Update the expected regression test results to account for the changes to · 485541a3
      Neil Conway authored
      error messages I made yesterday -- thanks to Andrew Dunstan for reporting
      this, and my apologies for missing it the first time.
      485541a3
    • Neil Conway's avatar
      Attached is a patch that replaces a bunch of places where StringInfos · 0d9742f9
      Neil Conway authored
      are unnecessarily allocated on the heap rather than the stack. If the
      StringInfo doesn't outlive the stack frame in which it is created,
      there is no need to allocate it on the heap via makeStringInfo() --
      stack allocation is faster.  While it's not a big deal unless the
      code is in a critical path, I don't see a reason not to save a few
      cycles -- using stack allocation is not less readable.
      
      I also cleaned up a bit of code along the way: moved variable
      declarations into a more tightly-enclosing scope where possible,
      fixed some pointless copying of strings in dblink, etc.
      0d9742f9
    • Neil Conway's avatar
      This patch makes the error message strings throughout the backend · 8e5a10d4
      Neil Conway authored
      more compliant with the error message style guide. In particular,
      errdetail should begin with a capital letter and end with a period,
      whereas errmsg should not. I also fixed a few related issues in
      passing, such as fixing the repeated misspelling of "lexeme" in
      contrib/tsearch2 (per Tom's suggestion).
      8e5a10d4
    • Neil Conway's avatar
      Fix typo in comment. · e24cea8b
      Neil Conway authored
      e24cea8b
  3. Feb 28, 2006
  4. Feb 27, 2006
  5. Feb 26, 2006
  6. Feb 24, 2006
    • Peter Eisentraut's avatar
      The Makefile was invoking perl scripts as ./script.pl. This fails when · 268c1b60
      Peter Eisentraut authored
      the script is not executable as UCS_to_most.pl is in CVS.  It also won't
      pick up any custom setting of the perl version/location to use.  This
      patch calls perl scripts like $(PERL) $(srcdir)/script.pl.
      
      Kris Jurka
      268c1b60
    • Andrew Dunstan's avatar
      · 2b695717
      Andrew Dunstan authored
      Make restricted_exec feature for Windows more robust by using the environment
      to pass the flag instead of the command line - some implementations of
      getopt fail if getopt arguments are present after non-getopt arguments.
      2b695717
    • Andrew Dunstan's avatar
      · b5fe16d0
      Andrew Dunstan authored
      make initdb -U username work as advertised; back out bogus patch at rev 1.42
      and supply real fix for problem it tried to address.
      b5fe16d0
  7. Feb 22, 2006
    • Neil Conway's avatar
      Cleanup the usage of ScanDirection: use the symbolic names for the · 737651f6
      Neil Conway authored
      possible ScanDirection alternatives rather than magic numbers
      (-1, 0, 1).  Also, use the ScanDirection macros in a few places
      rather than directly checking whether `dir == ForwardScanDirection'
      and the like. Per patch from James William Pye. His patch also
      changed ScanDirection to be a "char" rather than an enum, which
      I haven't applied.
      737651f6
  8. Feb 21, 2006
    • Tom Lane's avatar
      Fix old pg_dump oversight: default values for domains really need to be dumped · 3666260f
      Tom Lane authored
      by decompiling the typdefaultbin expression, not just printing the typdefault
      text which may be out-of-date or assume the wrong schema search path.  (It's
      the same hazard as for adbin vs adsrc in column defaults.)  The catalogs.sgml
      spec for pg_type implies that the correct procedure is to look to
      typdefaultbin first and consider typdefault only if typdefaultbin is NULL.
      I made dumping of both domains and base types do that, even though in the
      current backend code typdefaultbin is always correct for domains and
      typdefault for base types --- might as well try to future-proof it a little.
      Per bug report from Alexander Galler.
      3666260f
    • Tom Lane's avatar
      Adjust probe for getaddrinfo to cope with macro-ized definitions, such · af49a163
      Tom Lane authored
      as Tru64's.  Per previous discussion.
      af49a163
  9. Feb 20, 2006
    • Neil Conway's avatar
      Fix three Python reference leaks in PLy_traceback(). This would result · 45594a68
      Neil Conway authored
      in leaking memory when invoking a PL/Python procedure that raises an
      exception. Unfortunately this still leaks memory, but at least the
      largest leak has been plugged.
      
      This patch also fixes a reference counting mistake in PLy_modify_tuple()
      for 8.0, 8.1 and HEAD: we don't actually own a reference to `platt', so
      we shouldn't Py_DECREF() it.
      45594a68
  10. Feb 19, 2006
    • Tom Lane's avatar
      Update obsolete comment. · 21e2544a
      Tom Lane authored
      21e2544a
    • Tom Lane's avatar
      Modify logtape.c so that the initial LogicalTapeSetCreate call only · b34aa337
      Tom Lane authored
      allocates the control data.  The per-tape buffers are allocated only
      on first use.  This saves memory in situations where tuplesort.c
      overestimates the number of tapes needed (ie, there are fewer runs
      than tapes).  Also, this makes legitimate the coding in inittapes()
      that includes tape buffer space in the maximum-memory calculation:
      when inittapes runs, we've already expended the whole allowed memory
      on tuple storage, and so we'd better not allocate all the tape buffers
      until we've flushed some tuples out of memory.
      b34aa337
    • Tom Lane's avatar
      Improve tuplesort.c to support variable merge order. The original coding · df700e6b
      Tom Lane authored
      with fixed merge order (fixed number of "tapes") was based on obsolete
      assumptions, namely that tape drives are expensive.  Since our "tapes"
      are really just a couple of buffers, we can have a lot of them given
      adequate workspace.  This allows reduction of the number of merge passes
      with consequent savings of I/O during large sorts.
      
      Simon Riggs with some rework by Tom Lane
      df700e6b
    • Neil Conway's avatar
      Add TABLESPACE and ON COMMIT clauses to CREATE TABLE AS. ON COMMIT is · 85c0eac1
      Neil Conway authored
      required by the SQL standard, and TABLESPACE is useful functionality.
      Patch from Kris Jurka, minor editorialization by Neil Conway.
      85c0eac1
  11. Feb 18, 2006
  12. Feb 17, 2006
  13. Feb 15, 2006
  14. Feb 14, 2006
  15. Feb 13, 2006
Loading