- Mar 02, 2006
-
-
Tom Lane authored
them to use array_recv :-(. Per report from Tim Kordas.
-
Tom Lane authored
then modified within the same transaction. The code was using a linked list of active PLpgSQL_expr structs, which was OK when it was written because plpgsql never released any parse data structures for the life of the backend. But since Neil fixed plpgsql's memory management, elements of the linked list could be freed, leading to crash when the list is chased. Per report and test case from Kris Jurka.
-
Tom Lane authored
make use of the recently added ability to create a shell type explicitly. I also put in place some infrastructure to allow dump/no dump decisions to be made separately for each database object, rather than the former hardwired 'dump if in a dumpable schema' policy. This was needed anyway for shell types so now seemed a convenient time to do it. The flexibility isn't exposed to the user yet, but is ready for future extensions.
-
- Mar 01, 2006
-
-
Neil Conway authored
error messages I made yesterday -- thanks to Andrew Dunstan for reporting this, and my apologies for missing it the first time.
-
Neil Conway authored
are unnecessarily allocated on the heap rather than the stack. If the StringInfo doesn't outlive the stack frame in which it is created, there is no need to allocate it on the heap via makeStringInfo() -- stack allocation is faster. While it's not a big deal unless the code is in a critical path, I don't see a reason not to save a few cycles -- using stack allocation is not less readable. I also cleaned up a bit of code along the way: moved variable declarations into a more tightly-enclosing scope where possible, fixed some pointless copying of strings in dblink, etc.
-
Neil Conway authored
more compliant with the error message style guide. In particular, errdetail should begin with a capital letter and end with a period, whereas errmsg should not. I also fixed a few related issues in passing, such as fixing the repeated misspelling of "lexeme" in contrib/tsearch2 (per Tom's suggestion).
-
Neil Conway authored
-
- Feb 28, 2006
-
-
Tom Lane authored
creation of a shell type. This allows a less hacky way of dealing with the mutual dependency between a datatype and its I/O functions: make a shell type, then make the functions, then define the datatype fully. We should fix pg_dump to handle things this way, but this commit just deals with the backend. Martijn van Oosterhout, with some corrections by Tom Lane.
-
Neil Conway authored
does not return None, per suggestion from Tom.
-
Neil Conway authored
(I didn't use his patch, however). A void-returning PL/Python function must return None (from Python), which is translated into a void datum (and *not* NULL) for Postgres. I also added some regression tests for this functionality.
-
Bruce Momjian authored
backend version in C using > and < comparisons.
-
Tom Lane authored
when the passed-down eflags indicate they can. Simon Riggs and Tom Lane
-
Tom Lane authored
bits indicating which optional capabilities can actually be exercised at runtime. This will allow Sort and Material nodes, and perhaps later other nodes, to avoid unnecessary overhead in common cases. This commit just adds the infrastructure and arranges to pass the correct flag values down to plan nodes; none of the actual optimizations are here yet. I'm committing this separately in case anyone wants to measure the added overhead. (It should be negligible.) Simon Riggs and Tom Lane
-
- Feb 27, 2006
-
-
Peter Eisentraut authored
particular get rid of single quotes around language names and old WITH () construct.
-
Bruce Momjian authored
-
- Feb 26, 2006
-
-
Tom Lane authored
each tuple, as per my proposal of several days ago. Also, clean up sort memory management by keeping all working data in a separate memory context, and refine the handling of low-memory conditions.
-
Neil Conway authored
-
Neil Conway authored
Kirkwood, minor improvements by Neil Conway. The regression tests have been updated and the catversion has been bumped.
-
Neil Conway authored
-
- Feb 24, 2006
-
-
Peter Eisentraut authored
the script is not executable as UCS_to_most.pl is in CVS. It also won't pick up any custom setting of the perl version/location to use. This patch calls perl scripts like $(PERL) $(srcdir)/script.pl. Kris Jurka
-
Andrew Dunstan authored
Make restricted_exec feature for Windows more robust by using the environment to pass the flag instead of the command line - some implementations of getopt fail if getopt arguments are present after non-getopt arguments.
-
Andrew Dunstan authored
make initdb -U username work as advertised; back out bogus patch at rev 1.42 and supply real fix for problem it tried to address.
-
- Feb 22, 2006
-
-
Neil Conway authored
possible ScanDirection alternatives rather than magic numbers (-1, 0, 1). Also, use the ScanDirection macros in a few places rather than directly checking whether `dir == ForwardScanDirection' and the like. Per patch from James William Pye. His patch also changed ScanDirection to be a "char" rather than an enum, which I haven't applied.
-
- Feb 21, 2006
-
-
Tom Lane authored
by decompiling the typdefaultbin expression, not just printing the typdefault text which may be out-of-date or assume the wrong schema search path. (It's the same hazard as for adbin vs adsrc in column defaults.) The catalogs.sgml spec for pg_type implies that the correct procedure is to look to typdefaultbin first and consider typdefault only if typdefaultbin is NULL. I made dumping of both domains and base types do that, even though in the current backend code typdefaultbin is always correct for domains and typdefault for base types --- might as well try to future-proof it a little. Per bug report from Alexander Galler.
-
Tom Lane authored
as Tru64's. Per previous discussion.
-
- Feb 20, 2006
-
-
Neil Conway authored
in leaking memory when invoking a PL/Python procedure that raises an exception. Unfortunately this still leaks memory, but at least the largest leak has been plugged. This patch also fixes a reference counting mistake in PLy_modify_tuple() for 8.0, 8.1 and HEAD: we don't actually own a reference to `platt', so we shouldn't Py_DECREF() it.
-
- Feb 19, 2006
-
-
Tom Lane authored
-
Tom Lane authored
allocates the control data. The per-tape buffers are allocated only on first use. This saves memory in situations where tuplesort.c overestimates the number of tapes needed (ie, there are fewer runs than tapes). Also, this makes legitimate the coding in inittapes() that includes tape buffer space in the maximum-memory calculation: when inittapes runs, we've already expended the whole allowed memory on tuple storage, and so we'd better not allocate all the tape buffers until we've flushed some tuples out of memory.
-
Tom Lane authored
with fixed merge order (fixed number of "tapes") was based on obsolete assumptions, namely that tape drives are expensive. Since our "tapes" are really just a couple of buffers, we can have a lot of them given adequate workspace. This allows reduction of the number of merge passes with consequent savings of I/O during large sorts. Simon Riggs with some rework by Tom Lane
-
Neil Conway authored
required by the SQL standard, and TABLESPACE is useful functionality. Patch from Kris Jurka, minor editorialization by Neil Conway.
-
- Feb 18, 2006
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
up a bunch of the support utilities. In src/backend/utils/mb/Unicode remove nearly duplicate copies of the UCS_to_XXX perl script and replace with one version to handle all generic files. Update the Makefile so that it knows about all the map files. This produces a slight difference in some of the map files, using a uniform naming convention and not mapping the null character. In src/backend/utils/mb/conversion_procs create a master utf8<->win codepage function like the ISO 8859 versions instead of having a separate handler for each conversion. There is an externally visible change in the name of the win1258 to utf8 conversion. According to the documentation notes, it was named incorrectly and this changes it to a standard name. Running the Unicode mapping perl scripts has shown some additional mapping changes in koi8r and iso8859-7.
-
Neil Conway authored
is only used by scan.l/scan.c
-
- Feb 17, 2006
-
-
Neil Conway authored
-
Peter Eisentraut authored
64-bit platforms. by ITAGAKI Takahiro
-
- Feb 15, 2006
-
-
Tom Lane authored
Simon Riggs
-
- Feb 14, 2006
-
-
Tom Lane authored
we are not holding a buffer content lock; where it was, InterruptHoldoffCount is positive and so we'd not respond to cancel signals as intended. Also add missing vacuum_delay_point() call in btvacuumcleanup. This should fix complaint from Evgeny Gridasov about failure to respond to SIGINT/SIGTERM in a timely fashion (bug #2257).
-
Tom Lane authored
-
Tom Lane authored
-
- Feb 13, 2006
-
-
Tom Lane authored
option state hasn't been fully set up. This is possible via PQreset() and might occur in other code paths too, so a state flag seems the most robust solution. Per report from Arturs Zoldners.
-