Skip to content
Snippets Groups Projects
  1. Jul 05, 2017
  2. May 18, 2017
  3. May 11, 2017
  4. Feb 09, 2017
  5. Jan 14, 2017
  6. Oct 19, 2016
    • Heikki Linnakangas's avatar
      Fix WAL-logging of FSM and VM truncation. · 917dc7d2
      Heikki Linnakangas authored
      When a relation is truncated, it is important that the FSM is truncated as
      well. Otherwise, after recovery, the FSM can return a page that has been
      truncated away, leading to errors like:
      
      ERROR:  could not read block 28991 in file "base/16390/572026": read only 0
      of 8192 bytes
      
      We were using MarkBufferDirtyHint() to dirty the buffer holding the last
      remaining page of the FSM, but during recovery, that might in fact not
      dirty the page, and the FSM update might be lost.
      
      To fix, use the stronger MarkBufferDirty() function. MarkBufferDirty()
      requires us to do WAL-logging ourselves, to protect from a torn page, if
      checksumming is enabled.
      
      Also fix an oversight in visibilitymap_truncate: it also needs to WAL-log
      when checksumming is enabled.
      
      Analysis by Pavan Deolasee.
      
      Discussion: <CABOikdNr5vKucqyZH9s1Mh0XebLs_jRhKv6eJfNnD2wxTn=_9A@mail.gmail.com>
      917dc7d2
Loading