Skip to content
Snippets Groups Projects
  1. Jul 06, 2010
    • Tom Lane's avatar
      Fix a few single-file (MODULES, not MODULE_big) contrib makefiles that were · f9e9da66
      Tom Lane authored
      supposing that they should set SHLIB_LINK rather than LDFLAGS_SL.  Since these
      don't go through Makefile.shlib that was a no-op on most platforms.  Also
      regularize the few platform-specific Makefiles that did pay attention to
      SHLIB_LINK: it seems that the real value of that is to pull in BE_DLLLIBS,
      so do that instead.  Per buildfarm failures on cygwin.
      f9e9da66
  2. Jun 11, 2009
  3. Jan 07, 2009
  4. May 17, 2008
    • Andrew Dunstan's avatar
      Add $PostgreSQL$ markers to a lot of files that were missing them. · 53972b46
      Andrew Dunstan authored
      This particular batch was just for *.c and *.h file.
      
      The changes were made with the following 2 commands:
      
      find . \( \( -name 'libstemmer' -o -name 'expected' -o -name 'ppport.h' \) -prune \) -o  \( -name '*.[ch]'  \) \( -exec grep -q '\$PostgreSQL' {} \; -o -print \) | while read file ; do head -n 1 < $file | grep -q '^/\*' && echo $file; done | xargs -l sed -i -e '1s/^\// /' -e '1i/*\n * $PostgreSQL:$ \n *'
      
      find . \( \( -name 'libstemmer' -o -name 'expected' -o -name 'ppport.h' \) -prune \) -o  \( -name '*.[ch]'  \) \( -exec grep -q '\$PostgreSQL' {} \; -o -print \) | xargs -l sed -i -e '1i/*\n * $PostgreSQL:$ \n */'
      53972b46
  5. Mar 25, 2008
    • Tom Lane's avatar
      Simplify and standardize conversions between TEXT datums and ordinary C · 220db7cc
      Tom Lane authored
      strings.  This patch introduces four support functions cstring_to_text,
      cstring_to_text_with_len, text_to_cstring, and text_to_cstring_buffer, and
      two macros CStringGetTextDatum and TextDatumGetCString.  A number of
      existing macros that provided variants on these themes were removed.
      
      Most of the places that need to make such conversions now require just one
      function or macro call, in place of the multiple notational layers that used
      to be needed.  There are no longer any direct calls of textout or textin,
      and we got most of the places that were using handmade conversions via
      memcpy (there may be a few still lurking, though).
      
      This commit doesn't make any serious effort to eliminate transient memory
      leaks caused by detoasting toasted text objects before they reach
      text_to_cstring.  We changed PG_GETARG_TEXT_P to PG_GETARG_TEXT_PP in a few
      places where it was easy, but much more could be done.
      
      Brendan Jurd and Tom Lane
      220db7cc
  6. Dec 03, 2007
  7. Nov 13, 2007
  8. Jun 27, 2007
  9. Mar 16, 2007
    • Tom Lane's avatar
      Make use of plancache module for SPI plans. In particular, since plpgsql · 95f6d2d2
      Tom Lane authored
      uses SPI plans, this finally fixes the ancient gotcha that you can't
      drop and recreate a temp table used by a plpgsql function.
      
      Along the way, clean up SPI's API a little bit by declaring SPI plan
      pointers as "SPIPlanPtr" instead of "void *".  This is cosmetic but
      helps to forestall simple programming mistakes.  (I have changed some
      but not all of the callers to match; there are still some "void *"'s
      in contrib and the PL's.  This is intentional so that we can see if
      anyone's compiler complains about it.)
      95f6d2d2
  10. Feb 01, 2007
    • Bruce Momjian's avatar
      Wording cleanup for error messages. Also change can't -> cannot. · 8b4ff8b6
      Bruce Momjian authored
      Standard English uses "may", "can", and "might" in different ways:
      
              may - permission, "You may borrow my rake."
      
              can - ability, "I can lift that log."
      
              might - possibility, "It might rain today."
      
      Unfortunately, in conversational English, their use is often mixed, as
      in, "You may use this variable to do X", when in fact, "can" is a better
      choice.  Similarly, "It may crash" is better stated, "It might crash".
      8b4ff8b6
  11. Jul 11, 2006
  12. May 31, 2006
  13. Mar 11, 2006
  14. Feb 27, 2006
  15. Oct 15, 2005
  16. Sep 27, 2005
  17. Jun 30, 2005
    • Tom Lane's avatar
      Clean up the rather historically encumbered interface to now() and · b5f7cff8
      Tom Lane authored
      current time: provide a GetCurrentTimestamp() function that returns
      current time in the form of a TimestampTz, instead of separate time_t
      and microseconds fields.  This is what all the callers really want
      anyway, and it eliminates low-level dependencies on AbsoluteTime,
      which is a deprecated datatype that will have to disappear eventually.
      b5f7cff8
  18. Nov 17, 2004
  19. Oct 07, 2004
  20. Aug 29, 2004
  21. Aug 20, 2004
    • Bruce Momjian's avatar
      > Please find enclose a submission to fix these problems. · ee85595d
      Bruce Momjian authored
      >
      > The patch adds missing the "libpgport.a" file to the installation under
      > "install-all-headers". It is needed by some contribs. I install the
      > library in "pkglibdir", but I was wondering whether it should be "libdir"?
      > I was wondering also whether it would make sense to have a "libpgport.so"?
      >
      > It fixes various macros which are used by contrib makefiles, especially
      > libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are
      > needed to
      >
      > It adds the ability to test and use PGXS with contribs, with "make
      > USE_PGXS=1". Without the macro, this is exactly as before, there should be
      > no difference, esp. wrt the vpath feature that seemed broken by previous
      > submission. So it should not harm anybody, and it is useful at least to me.
      >
      > It fixes some inconsistencies in various contrib makefiles
      > (useless override, ":=" instead of "=").
      
      Fabien COELHO
      ee85595d
  22. May 07, 2004
    • Tom Lane's avatar
      Solve the 'Turkish problem' with undesirable locale behavior for case · 0bd61548
      Tom Lane authored
      conversion of basic ASCII letters.  Remove all uses of strcasecmp and
      strncasecmp in favor of new functions pg_strcasecmp and pg_strncasecmp;
      remove most but not all direct uses of toupper and tolower in favor of
      pg_toupper and pg_tolower.  These functions use the same notions of
      case folding already developed for identifier case conversion.  I left
      the straight locale-based folding in place for situations where we are
      just manipulating user data and not trying to match it to built-in
      strings --- for example, the SQL upper() function is still locale
      dependent.  Perhaps this will prove not to be what's wanted, but at
      the moment we can initdb and pass regression tests in Turkish locale.
      0bd61548
  23. Nov 29, 2003
    • PostgreSQL Daemon's avatar
      · 969685ad
      PostgreSQL Daemon authored
      $Header: -> $PostgreSQL Changes ...
      969685ad
  24. Sep 11, 2003
    • Bruce Momjian's avatar
      on my timetravel.c I find a bug: after the · a5e9e51f
      Bruce Momjian authored
      ALTER TABLE mytable drop column last_column_of_table;
      
      the timetravel trigger say on UPDATE/DELETE:
      
      ERROR:  parser: parse error at end of input
      
      
      Here is the patch for this bug
      
      B?jthe Zolt?n
      a5e9e51f
  25. Aug 04, 2003
  26. Jul 27, 2003
    • Tom Lane's avatar
      Remove unportable // comments. · aeea73d4
      Tom Lane authored
      aeea73d4
    • Bruce Momjian's avatar
      Cleanup of timetravel compile warnings. · b29c557e
      Bruce Momjian authored
      b29c557e
    • Bruce Momjian's avatar
      Here is 4 file in tgz: · 524cfad2
      Bruce Momjian authored
      the new timetravel.c,
      new timetravel.README (cut from spi/README and modified),
      modified timetravel.sql.in
      and modified timetravel.example.
      
      Features:
      - optionally 3 parameter for insert/update/delete user name
      
      - work with CREATE UNIQUE INDEX ixxx on table xxx
      (unique_field,time_off);
          (the  original version was work with unique index on 6.5.0-6.5.3,
      and not work on 7.3.2,7.3.3)
           (before 6.5.0 and between 6.5.3 and 7.3.2 I dont know)
      
      - get_timetravel(tablename) function for check timetravel-status.
      
      - timetravel trigger not change  oid of the active record. (it is not a
      good feature, because the  old version is automatice prevent the paralel
      update with "where oid=nnn")
      
      B?jthe Zolt?n
      524cfad2
  27. Jul 24, 2003
  28. Jun 11, 2003
  29. May 27, 2003
  30. May 14, 2003
  31. Mar 10, 2003
  32. Jan 09, 2003
  33. Oct 18, 2002
  34. Oct 03, 2002
  35. Sep 05, 2002
  36. Sep 04, 2002
  37. Sep 02, 2002
    • Bruce Momjian's avatar
      I checked all the previous string handling errors and most of them were · a12b4e27
      Bruce Momjian authored
      already fixed by You. However there were a few left and attached patch
      should fix the rest of them.
      
      I used StringInfo only in 2 places and both of them are inside debug
      ifdefs. Only performance penalty will come from using strlen() like all
      the other code does.
      
      I also modified some of the already patched parts by changing
      snprintf(buf, 2 * BUFSIZE, ... style lines to
      snprintf(buf, sizeof(buf), ... where buf is an array.
      
      Jukka Holappa
      a12b4e27
Loading