Skip to content
Snippets Groups Projects
  1. Aug 25, 1998
  2. Aug 24, 1998
    • Bruce Momjian's avatar
      This is the final state of the rule system for 6.4 after the · 15cb32d9
      Bruce Momjian authored
          patch is applied:
      
      	Rewrite rules on relation level work fine now.
      
      	Event qualifications on insert/update/delete  rules  work
      	fine now.
      
      	I  added  the  new  keyword  OLD to reference the CURRENT
      	tuple. CURRENT will be removed in 6.5.
      
      	Update rules can  reference  NEW  and  OLD  in  the  rule
      	qualification and the actions.
      
      	Insert/update/delete rules on views can be established to
      	let them behave like real tables.
      
      	For  insert/update/delete  rules  multiple  actions   are
      	supported  now.   The  actions  can also be surrounded by
      	parantheses to make psql  happy.   Multiple  actions  are
      	required if update to a view requires updates to multiple
      	tables.
      
      	Regular users  are  permitted  to  create/drop  rules  on
      	tables     they     have     RULE     permissions     for
      	(DefineQueryRewrite() is  now  able  to  get  around  the
      	access  restrictions  on  pg_rewrite).  This enables view
      	creation for regular users too. This  required  an  extra
      	boolean  parameter  to  pg_parse_and_plan() that tells to
      	set skipAcl on all rangetable entries  of  the  resulting
      	queries.       There      is      a      new     function
      	pg_exec_query_acl_override()  that  could  be   used   by
      	backend utilities to use this facility.
      
      	All rule actions (not only views) inherit the permissions
      	of the event relations  owner.  Sample:  User  A  creates
      	tables    T1    and    T2,   creates   rules   that   log
      	INSERT/UPDATE/DELETE on T1 in T2 (like in the  regression
      	tests  for rules I created) and grants ALL but RULE on T1
      	to user B.  User B  can  now  fully  access  T1  and  the
      	logging  happens  in  T2.  But user B cannot access T2 at
      	all, only the rule actions can. And due to  missing  RULE
      	permissions on T1, user B cannot disable logging.
      
      	Rules  on  the  attribute  level are disabled (they don't
      	work properly and since regular users are  now  permitted
      	to create rules I decided to disable them).
      
      	Rules  on  select  must have exactly one action that is a
      	select (so select rules must be a view definition).
      
      	UPDATE NEW/OLD rules  are  disabled  (still  broken,  but
      	triggers can do it).
      
      	There are two new system views (pg_rule and pg_view) that
      	show the definition of the rules or views so the db admin
      	can  see  what  the  users do. They use two new functions
      	pg_get_ruledef() and pg_get_viewdef() that are  builtins.
      
      	The functions pg_get_ruledef() and pg_get_viewdef() could
      	be used to implement rule and view support in pg_dump.
      
      	PostgreSQL is now the only database system I  know,  that
      	has rewrite rules on the query level. All others (where I
      	found a  rule  statement  at  all)  use  stored  database
      	procedures  or  the  like  (triggers as we call them) for
      	active rules (as some call them).
      
          Future of the rule system:
      
      	The now disabled parts  of  the  rule  system  (attribute
      	level,  multiple  actions on select and update new stuff)
      	require a complete new rewrite handler from scratch.  The
      	old one is too badly wired up.
      
      	After  6.4  I'll  start to work on a new rewrite handler,
      	that fully supports the attribute level  rules,  multiple
      	actions on select and update new.  This will be available
      	for 6.5 so we get full rewrite rule capabilities.
      
      Jan
      15cb32d9
    • Bruce Momjian's avatar
      o note that now pg_database has a new attribuite "encoding" even · c0b01461
      Bruce Momjian authored
      if MULTIBYTE is not enabled. So be sure to run initdb.
      
      o these patches are made against the latest source tree (after
      Bruce's massive patch, I think) BTW, I noticed that after running
      regression, the oid field of pg_type seems disappeared.
      
      	regression=> select oid from pg_type; ERROR:  attribute
      	'oid' not found
      
      this happens after the constraints test. This occures with/without
      my patches. strange...
      
      o pg_database_mb.h, pg_class_mb.h, pg_attribute_mb.h are no longer
      used, and shoud be removed.
      
      o GetDatabaseInfo() in utils/misc/database.c removed (actually in
      #ifdef 0). seems nobody uses.
      
      t-ishii@sra.co.jp
      c0b01461
    • Bruce Momjian's avatar
      Attached is a patch that uses autoconf to determine whether there · 07ae591c
      Bruce Momjian authored
      is a working 64-bit-int type available.
      
      In playing around with it on my machine, I found that gcc provides
      perfectly fine support for "long long" arithmetic ... but sprintf()
      and sscanf(), which are system-supplied, don't work :-(.  So the
      autoconf test program does a cursory test on them too.
      
      If we find that a lot of systems are like this, it might be worth
      the trouble to implement binary<->ASCII conversion of int64 ourselves
      rather than relying on sprintf/sscanf to handle the data type.
      
      			regards, tom lane
      07ae591c
  3. Aug 22, 1998
    • Bruce Momjian's avatar
      · a738478a
      Bruce Momjian authored
      Here are additional patches for the UnixWare 7 port.
      
      Summary of changes:
      
      In pqcomm.h, use the SUN_LEN macro if it is defined to calculate
      the size of the sockaddr_un structure.
      
      In unixware.h, drop the use of the UNIXWARE macro.  Everything can
      be handled with the USE_UNIVEL_CC and DISABLE_COMPLEX_MACRO macros.
      
      In s_lock.h, remove the reference to the UNIXWARE macro (see above).
      
      In the unixware template, add the YFLAGS:-d line.
      
      In various makefile templates, add (or cleanup) unixware and univel
      port specific information.
      
      -- Billy G. Allie
      a738478a
  4. Aug 19, 1998
    • Bruce Momjian's avatar
      Vacuum fix. Was modifying cache. · bd5aaca3
      Bruce Momjian authored
      bd5aaca3
    • Bruce Momjian's avatar
      heap_fetch requires buffer pointer, must be released; heap_getnext · 79715390
      Bruce Momjian authored
      no longer returns buffer pointer, can be gotten from scan;
      	descriptor; bootstrap can create multi-key indexes;
      pg_procname index now is multi-key index; oidint2, oidint4, oidname
      are gone (must be removed from regression tests); use System Cache
      rather than sequential scan in many places; heap_modifytuple no
      longer takes buffer parameter; remove unused buffer parameter in
      a few other functions; oid8 is not index-able; remove some use of
      single-character variable names; cleanup Buffer variables usage
      and scan descriptor looping; cleaned up allocation and freeing of
      tuples; 18k lines of diff;
      79715390
  5. Aug 18, 1998
    • Marc G. Fournier's avatar
      · 338c54cb
      Marc G. Fournier authored
      From: Jan Wieck <jwieck@debis.com>
      
      Hi,
      
          as  proposed here comes the first patch for the query rewrite
          system.
      
        <for details, see archive dated Mon, 17 Aug 1998>
      338c54cb
  6. Aug 15, 1998
  7. Aug 14, 1998
  8. Aug 12, 1998
  9. Aug 11, 1998
  10. Aug 10, 1998
  11. Aug 09, 1998
  12. Aug 06, 1998
  13. Aug 05, 1998
    • Marc G. Fournier's avatar
      · a1627a1d
      Marc G. Fournier authored
      From: David Hartwig <daybee@bellatlantic.net>
      
      I have attached a patch to allow GROUP BY and/or ORDER BY function or
      expressions.  Note worthy items:
      
      1. The expression or function need not be in the target list.
      Example:
                  SELECT  name FROM foo GROUP BY lower(name);
      
      2.   Simplified the grammar to use expressions only.
      
      3.  Cleaned up earlier patch in this area to make use of existing
      utility functions.
      
      3.  Reduced some of the members in the SortGroupBy parse node.   The
      original data members were redundant with the new expression node.
      (MUST do a "make clean" now)
      
      4.  Added a new parse node "JoinUsing".   The JOIN USING clause was
      overloading this SortGroupBy structure.   With the afore mentioned
      reduction of members, the two clauses lost all their commonality.
      
      5.  A bug still exist where, if a function or expression is GROUPed BY,
      and an aggregate function does not include a attribute from the
      expression or function, the backend crashes.   (or something like
      that)   The bug pre-dates this patch.    Example:
      
          SELECT lower(a) AS lowcase, count(b) FROM foo GROUP BY lowcase;
                       *** BOOM  ***
      
          --Also when not in target list
          SELECT  count(b) FROM foo GROUP BY lower(a);
                      *** BOOM  AGAIN ***
      a1627a1d
  14. Aug 04, 1998
  15. Aug 03, 1998
  16. Aug 01, 1998
    • Marc G. Fournier's avatar
      · 0668aa88
      Marc G. Fournier authored
      Adrian Hall reported a problem to me that snprintf() doesn't exist in, at
      least, Solaris 2.5.1.  We use it in backend/utils/adt/int8.c.
      
      Add a check to configure so that we see if it exists or not, and, if not,
      compile in snprintf.c from backend/port, which was taken from, and falls under
      the same Berkeley license as us, the FreeBSD libc/stdio ...
      0668aa88
    • Vadim B. Mikheev's avatar
      0d78e8c1
  17. Jul 30, 1998
  18. Jul 27, 1998
  19. Jul 26, 1998
    • Marc G. Fournier's avatar
      · 5979d738
      Marc G. Fournier authored
      From: t-ishii@sra.co.jp
      
      As Bruce mentioned, this is due to the conflict among changes we made.
      Included patches should fix the problem(I changed all MB to
      MULTIBYTE). Please let me know if you have further problem.
      
      P.S. I did not include pathces to configure and gram.c to save the
      file size(configure.in and gram.y modified).
      5979d738
  20. Jul 24, 1998
    • Marc G. Fournier's avatar
      · bf00bbb0
      Marc G. Fournier authored
      I really hope that I haven't missed anything in this one...
      
      From: t-ishii@sra.co.jp
      
      Attached are patches to enhance the multi-byte support.  (patches are
      against 7/18 snapshot)
      
      * determine encoding at initdb/createdb rather than compile time
      
      Now initdb/createdb has an option to specify the encoding. Also, I
      modified the syntax of CREATE DATABASE to accept encoding option. See
      README.mb for more details.
      
      For this purpose I have added new column "encoding" to pg_database.
      Also pg_attribute and pg_class are changed to catch up the
      modification to pg_database.  Actually I haved added pg_database_mb.h,
      pg_attribute_mb.h and pg_class_mb.h. These are used only when MB is
      enabled. The reason having separate files is I couldn't find a way to
      use ifdef or whatever in those files. I have to admit it looks
      ugly. No way.
      
      * support for PGCLIENTENCODING when issuing COPY command
      
      commands/copy.c modified.
      
      * support for SQL92 syntax "SET NAMES"
      
      See gram.y.
      
      * support for LATIN2-5
      * add UNICODE regression test case
      * new test suite for MB
      
      New directory test/mb added.
      
      * clean up source files
      
      Basic idea is to have MB's own subdirectory for easier maintenance.
      These are include/mb and backend/utils/mb.
      bf00bbb0
  21. Jul 21, 1998
    • Vadim B. Mikheev's avatar
    • Bruce Momjian's avatar
      Theses buffer leaks are caused by indexes that are kept open between · e0058b61
      Bruce Momjian authored
      calls. Outside a transaction, the backend detects them as buffer
      leaks; it sends a NOTICE, and frees them. This sometimes cause a
      segmentation fault (at least on Linux). These indexes are initialized
      on the first lo_read/lo_write/lo_tell call, and (normally) closed
      on a lo_close call.  Thus the buffer leaks appear when lo direct
      access functions are used, and not with lo_import/lo_export functions
      (libpq version calls lo_close before ending the command, and the
      backend version uses another path).
      
      The included patches (against recent snapshot, and against 6.3.2)
      cause indexes to be closed on transaction end (that is on explicit
      'END' statment, or on command termination outside trasaction blocks),
      thus preventing the buffer leaks while increasing performance inside
      transactions. Some (all?) 'classic' memory leaks are also removed.
      
      I hope it will be ok.
      
      --- Pascal ANDRE, graduated from Ecole Centrale Paris andre@via.ecp.fr
      e0058b61
  22. Jul 20, 1998
  23. Jul 19, 1998
Loading