-
- Downloads
I've created a new shared catalog table pg_shdescription to store
comments on cluster global objects like databases, tablespaces, and roles. It touches a lot of places, but not much in the way of big changes. The only design decision I made was to duplicate the query and manipulation functions rather than to try and have them handle both shared and local comments. I believe this is simpler for the code and not an issue for callers because they know what type of object they are dealing with. This has resulted in a shobj_description function analagous to obj_description and backend functions [Create/Delete]SharedComments mirroring the existing [Create/Delete]Comments functions. pg_shdescription.h goes into src/include/catalog/ Kris Jurka
Showing
- doc/src/sgml/catalogs.sgml 79 additions, 1 deletiondoc/src/sgml/catalogs.sgml
- doc/src/sgml/func.sgml 18 additions, 1 deletiondoc/src/sgml/func.sgml
- doc/src/sgml/ref/comment.sgml 12 additions, 9 deletionsdoc/src/sgml/ref/comment.sgml
- src/backend/catalog/Makefile 6 additions, 3 deletionssrc/backend/catalog/Makefile
- src/backend/catalog/genbki.sh 20 additions, 4 deletionssrc/backend/catalog/genbki.sh
- src/backend/commands/comment.c 215 additions, 18 deletionssrc/backend/commands/comment.c
- src/backend/commands/dbcommands.c 2 additions, 4 deletionssrc/backend/commands/dbcommands.c
- src/backend/commands/tablespace.c 7 additions, 1 deletionsrc/backend/commands/tablespace.c
- src/backend/commands/user.c 7 additions, 1 deletionsrc/backend/commands/user.c
- src/backend/parser/gram.y 5 additions, 2 deletionssrc/backend/parser/gram.y
- src/bin/initdb/initdb.c 48 additions, 3 deletionssrc/bin/initdb/initdb.c
- src/bin/pg_dump/pg_dump.c 36 additions, 5 deletionssrc/bin/pg_dump/pg_dump.c
- src/bin/pg_dump/pg_dumpall.c 40 additions, 6 deletionssrc/bin/pg_dump/pg_dumpall.c
- src/bin/psql/command.c 3 additions, 3 deletionssrc/bin/psql/command.c
- src/bin/psql/describe.c 13 additions, 7 deletionssrc/bin/psql/describe.c
- src/bin/psql/describe.h 2 additions, 2 deletionssrc/bin/psql/describe.h
- src/bin/psql/tab-complete.c 3 additions, 2 deletionssrc/bin/psql/tab-complete.c
- src/include/catalog/catversion.h 2 additions, 2 deletionssrc/include/catalog/catversion.h
- src/include/catalog/indexing.h 3 additions, 1 deletionsrc/include/catalog/indexing.h
- src/include/catalog/pg_database.h 2 additions, 2 deletionssrc/include/catalog/pg_database.h
Loading
Please register or sign in to comment