Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
postgres-lambda-diff
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jakob Huber
postgres-lambda-diff
Commits
f35e1c8c
Commit
f35e1c8c
authored
25 years ago
by
Tom Lane
Browse files
Options
Downloads
Patches
Plain Diff
Revise init_sequence so that it doesn't leak memory if the requested
sequence doesn't exist.
parent
8a40400d
No related branches found
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/backend/commands/sequence.c
+31
-31
31 additions, 31 deletions
src/backend/commands/sequence.c
with
31 additions
and
31 deletions
src/backend/commands/sequence.c
+
31
−
31
View file @
f35e1c8c
...
@@ -388,57 +388,57 @@ static SeqTable
...
@@ -388,57 +388,57 @@ static SeqTable
init_sequence
(
char
*
caller
,
char
*
name
)
init_sequence
(
char
*
caller
,
char
*
name
)
{
{
SeqTable
elm
,
SeqTable
elm
,
pr
i
v
=
(
SeqTable
)
NULL
;
pr
e
v
=
(
SeqTable
)
NULL
;
SeqTable
temp
;
Relation
seqrel
;
for
(
elm
=
seqtab
;
elm
!=
(
SeqTable
)
NULL
;)
/* Look to see if we already have a seqtable entry for name */
for
(
elm
=
seqtab
;
elm
!=
(
SeqTable
)
NULL
;
elm
=
elm
->
next
)
{
{
if
(
strcmp
(
elm
->
name
,
name
)
==
0
)
if
(
strcmp
(
elm
->
name
,
name
)
==
0
)
break
;
break
;
priv
=
elm
;
prev
=
elm
;
elm
=
elm
->
next
;
}
}
if
(
elm
==
(
SeqTable
)
NULL
)
/* not found */
/* If so, and if it's already been opened in this xact, just return it */
{
if
(
elm
!=
(
SeqTable
)
NULL
&&
elm
->
rel
!=
(
Relation
)
NULL
)
temp
=
(
SeqTable
)
malloc
(
sizeof
(
SeqTableData
));
temp
->
name
=
malloc
(
strlen
(
name
)
+
1
);
strcpy
(
temp
->
name
,
name
);
temp
->
rel
=
(
Relation
)
NULL
;
temp
->
cached
=
temp
->
last
=
temp
->
increment
=
0
;
temp
->
next
=
(
SeqTable
)
NULL
;
}
else
/* found */
{
if
(
elm
->
rel
!=
(
Relation
)
NULL
)
/* already opened */
return
elm
;
return
elm
;
temp
=
elm
;
}
temp
->
rel
=
heap_openr
(
name
,
AccessShareLock
);
/* Else open and check it */
seqrel
=
heap_openr
(
name
,
AccessShareLock
);
if
(
temp
->
rel
->
rd_rel
->
relkind
!=
RELKIND_SEQUENCE
)
if
(
seq
rel
->
rd_rel
->
relkind
!=
RELKIND_SEQUENCE
)
elog
(
ERROR
,
"%s.%s: %s is not sequence !"
,
name
,
caller
,
name
);
elog
(
ERROR
,
"%s.%s: %s is not sequence !"
,
name
,
caller
,
name
);
if
(
elm
!=
(
SeqTable
)
NULL
)
/* we opened sequence from our */
if
(
elm
!=
(
SeqTable
)
NULL
)
{
/* SeqTable - check relid ! */
{
if
(
RelationGetRelid
(
elm
->
rel
)
!=
elm
->
relid
)
/* We are using a seqtable entry left over from a previous xact;
* must check for relid change.
*/
elm
->
rel
=
seqrel
;
if
(
RelationGetRelid
(
seqrel
)
!=
elm
->
relid
)
{
{
elog
(
NOTICE
,
"%s.%s: sequence was re-created"
,
elog
(
NOTICE
,
"%s.%s: sequence was re-created"
,
name
,
caller
,
name
);
name
,
caller
,
name
);
elm
->
relid
=
RelationGetRelid
(
seqrel
);
elm
->
cached
=
elm
->
last
=
elm
->
increment
=
0
;
elm
->
cached
=
elm
->
last
=
elm
->
increment
=
0
;
elm
->
relid
=
RelationGetRelid
(
elm
->
rel
);
}
}
}
}
else
else
{
{
elm
=
temp
;
/* Time to make a new seqtable entry. These entries live as long
elm
->
relid
=
RelationGetRelid
(
elm
->
rel
);
* as the backend does, so we use plain malloc for them.
*/
elm
=
(
SeqTable
)
malloc
(
sizeof
(
SeqTableData
));
elm
->
name
=
malloc
(
strlen
(
name
)
+
1
);
strcpy
(
elm
->
name
,
name
);
elm
->
rel
=
seqrel
;
elm
->
relid
=
RelationGetRelid
(
seqrel
);
elm
->
cached
=
elm
->
last
=
elm
->
increment
=
0
;
elm
->
next
=
(
SeqTable
)
NULL
;
if
(
seqtab
==
(
SeqTable
)
NULL
)
if
(
seqtab
==
(
SeqTable
)
NULL
)
seqtab
=
elm
;
seqtab
=
elm
;
else
else
pr
i
v
->
next
=
elm
;
pr
e
v
->
next
=
elm
;
}
}
return
elm
;
return
elm
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment