Handle impending sinval queue overflow by means of a separate signal
(SIGUSR1, which we have not been using recently) instead of piggybacking on SIGUSR2-driven NOTIFY processing. This has several good results: the processing needed to drain the sinval queue is a lot less than the processing needed to answer a NOTIFY; there's less contention since we don't have a bunch of backends all trying to acquire exclusive lock on pg_listener; backends that are sitting inside a transaction block can still drain the queue, whereas NOTIFY processing can't run if there's an open transaction block. (This last is a fairly serious issue that I don't think we ever recognized before --- with clients like JDBC that tend to sit with open transaction blocks, the sinval queue draining mechanism never really worked as intended, probably resulting in a lot of useless cache-reset overhead.) This is the last of several proposed changes in response to Philip Warner's recent report of sinval-induced performance problems.
Showing
- src/backend/commands/async.c 23 additions, 11 deletionssrc/backend/commands/async.c
- src/backend/postmaster/postmaster.c 4 additions, 4 deletionssrc/backend/postmaster/postmaster.c
- src/backend/storage/ipc/sinval.c 230 additions, 1 deletionsrc/backend/storage/ipc/sinval.c
- src/backend/storage/ipc/sinvaladt.c 3 additions, 7 deletionssrc/backend/storage/ipc/sinvaladt.c
- src/backend/tcop/postgres.c 11 additions, 4 deletionssrc/backend/tcop/postgres.c
- src/include/commands/async.h 4 additions, 5 deletionssrc/include/commands/async.h
- src/include/storage/pmsignal.h 2 additions, 2 deletionssrc/include/storage/pmsignal.h
- src/include/storage/sinval.h 12 additions, 3 deletionssrc/include/storage/sinval.h
Loading
Please register or sign in to comment