-
- Downloads
Adjust definition of cheapest_total_path to work better with LATERAL.
In the initial cut at LATERAL, I kept the rule that cheapest_total_path was always unparameterized, which meant it had to be NULL if the relation has no unparameterized paths. It turns out to work much more nicely if we always have *some* path nominated as cheapest-total for each relation. In particular, let's still say it's the cheapest unparameterized path if there is one; if not, take the cheapest-total-cost path among those of the minimum available parameterization. (The first rule is actually a special case of the second.) This allows reversion of some temporary lobotomizations I'd put in place. In particular, the planner can now consider hash and merge joins for joins below a parameter-supplying nestloop, even if there aren't any unparameterized paths available. This should bring planning of LATERAL-containing queries to the same level as queries not using that feature. Along the way, simplify management of parameterized paths in add_path() and friends. In the original coding for parameterized paths in 9.2, I tried to minimize the logic changes in add_path(), so it just treated parameterization as yet another dimension of comparison for paths. We later made it ignore pathkeys (sort ordering) of parameterized paths, on the grounds that ordering isn't a useful property for the path on the inside of a nestloop, so we might as well get rid of useless parameterized paths as quickly as possible. But we didn't take that reasoning as far as we should have. Startup cost isn't a useful property inside a nestloop either, so add_path() ought to discount startup cost of parameterized paths as well. Having done that, the secondary sorting I'd implemented (in add_parameterized_path) is no longer needed --- any parameterized path that survives add_path() at all is worth considering at higher levels. So this should be a bit faster as well as simpler.
Showing
- src/backend/optimizer/README 16 additions, 1 deletionsrc/backend/optimizer/README
- src/backend/optimizer/geqo/geqo_eval.c 2 additions, 8 deletionssrc/backend/optimizer/geqo/geqo_eval.c
- src/backend/optimizer/path/allpaths.c 1 addition, 2 deletionssrc/backend/optimizer/path/allpaths.c
- src/backend/optimizer/path/joinpath.c 52 additions, 33 deletionssrc/backend/optimizer/path/joinpath.c
- src/backend/optimizer/plan/planmain.c 2 additions, 1 deletionsrc/backend/optimizer/plan/planmain.c
- src/backend/optimizer/util/pathnode.c 129 additions, 191 deletionssrc/backend/optimizer/util/pathnode.c
- src/include/nodes/relation.h 8 additions, 10 deletionssrc/include/nodes/relation.h
- src/test/regress/expected/join.out 7 additions, 6 deletionssrc/test/regress/expected/join.out
Loading
Please register or sign in to comment