-
- Downloads
Prevent accidental linking of system-supplied copies of libpq.so etc.
Back-patch commit dddfc4cb, which broke LDFLAGS and related Makefile variables into two parts, one for within-build-tree library references and one for external libraries, to ensure that the order of -L flags has all of the former before all of the latter. This turns out to fix a problem recently noted on buildfarm member peripatus, that we attempted to incorporate code from libpgport.a into a shared library. That will fail on platforms that are sticky about putting non-PIC code into shared libraries. (It's quite surprising we hadn't seen such failures before, since the code in question has been like that for a long time.) I think that peripatus' problem could have been fixed with just a subset of this patch; but since the previous issue of accidentally linking to the wrong copy of a Postgres shlib seems likely to bite people in the field, let's just back-patch the whole change. Now that commit dddfc4cb has survived some beta testing, I'm less afraid to back-patch it than I was at the time. This also fixes undesired inclusion of "-DFRONTEND" in pg_config's CPPFLAGS output (in 9.6 and up) and undesired inclusion of "-L../../src/common" in its LDFLAGS output (in all supported branches). Back-patch to v10 and older branches; this is already in v11. Discussion: https://postgr.es/m/20180704234304.bq2dxispefl65odz@ler-imac.local
Showing
- contrib/dblink/Makefile 1 addition, 1 deletioncontrib/dblink/Makefile
- contrib/oid2name/Makefile 1 addition, 1 deletioncontrib/oid2name/Makefile
- contrib/pgbench/Makefile 2 additions, 1 deletioncontrib/pgbench/Makefile
- contrib/postgres_fdw/Makefile 1 addition, 1 deletioncontrib/postgres_fdw/Makefile
- contrib/spi/Makefile 0 additions, 2 deletionscontrib/spi/Makefile
- contrib/vacuumlo/Makefile 1 addition, 1 deletioncontrib/vacuumlo/Makefile
- src/Makefile.global.in 17 additions, 8 deletionssrc/Makefile.global.in
- src/Makefile.shlib 8 additions, 2 deletionssrc/Makefile.shlib
- src/backend/replication/libpqwalreceiver/Makefile 1 addition, 1 deletionsrc/backend/replication/libpqwalreceiver/Makefile
- src/bin/pg_basebackup/Makefile 4 additions, 3 deletionssrc/bin/pg_basebackup/Makefile
- src/bin/pg_config/Makefile 1 addition, 1 deletionsrc/bin/pg_config/Makefile
- src/bin/pg_ctl/Makefile 2 additions, 1 deletionsrc/bin/pg_ctl/Makefile
- src/interfaces/ecpg/compatlib/Makefile 2 additions, 2 deletionssrc/interfaces/ecpg/compatlib/Makefile
- src/interfaces/ecpg/ecpglib/Makefile 2 additions, 1 deletionsrc/interfaces/ecpg/ecpglib/Makefile
- src/interfaces/ecpg/pgtypeslib/Makefile 1 addition, 1 deletionsrc/interfaces/ecpg/pgtypeslib/Makefile
- src/interfaces/ecpg/test/Makefile.regress 3 additions, 2 deletionssrc/interfaces/ecpg/test/Makefile.regress
- src/interfaces/ecpg/test/compat_informix/Makefile 1 addition, 2 deletionssrc/interfaces/ecpg/test/compat_informix/Makefile
- src/interfaces/libpq/test/Makefile 2 additions, 2 deletionssrc/interfaces/libpq/test/Makefile
- src/makefiles/pgxs.mk 3 additions, 1 deletionsrc/makefiles/pgxs.mk
- src/test/examples/Makefile 2 additions, 2 deletionssrc/test/examples/Makefile
Loading
Please register or sign in to comment