Consistently declare timestamp variables as TimestampTz.
Twiddle the replication-related code so that its timestamp variables are declared TimestampTz, rather than the uninformative "int64" that was previously used for meant-to-be-always-integer timestamps. This resolves the int64-vs-TimestampTz declaration inconsistencies introduced by commit 7c030783, though in the opposite direction to what was originally suggested. This required including datatype/timestamp.h in a couple more places than before. I decided it would be a good idea to slim down that header by not having it pull in <float.h> etc, as those headers are no longer at all relevant to its purpose. Unsurprisingly, a small number of .c files turn out to have been depending on those inclusions, so add them back in the .c files as needed. Discussion: https://postgr.es/m/26788.1487455319@sss.pgh.pa.us Discussion: https://postgr.es/m/27694.1487456324@sss.pgh.pa.us
Showing
- contrib/auth_delay/auth_delay.c 2 additions, 0 deletionscontrib/auth_delay/auth_delay.c
- contrib/btree_gist/btree_ts.c 2 additions, 0 deletionscontrib/btree_gist/btree_ts.c
- src/backend/access/common/reloptions.c 2 additions, 0 deletionssrc/backend/access/common/reloptions.c
- src/backend/access/transam/xlog.c 1 addition, 0 deletionssrc/backend/access/transam/xlog.c
- src/backend/commands/prepare.c 2 additions, 0 deletionssrc/backend/commands/prepare.c
- src/backend/executor/nodeBitmapHeapscan.c 2 additions, 0 deletionssrc/backend/executor/nodeBitmapHeapscan.c
- src/backend/replication/basebackup.c 6 additions, 6 deletionssrc/backend/replication/basebackup.c
- src/backend/replication/logical/worker.c 6 additions, 8 deletionssrc/backend/replication/logical/worker.c
- src/backend/replication/walreceiver.c 4 additions, 6 deletionssrc/backend/replication/walreceiver.c
- src/backend/replication/walsender.c 5 additions, 4 deletionssrc/backend/replication/walsender.c
- src/backend/tcop/pquery.c 2 additions, 0 deletionssrc/backend/tcop/pquery.c
- src/backend/utils/adt/nabstime.c 1 addition, 0 deletionssrc/backend/utils/adt/nabstime.c
- src/backend/utils/cache/inval.c 2 additions, 0 deletionssrc/backend/utils/cache/inval.c
- src/backend/utils/time/snapmgr.c 24 additions, 21 deletionssrc/backend/utils/time/snapmgr.c
- src/bin/pg_basebackup/pg_recvlogical.c 9 additions, 9 deletionssrc/bin/pg_basebackup/pg_recvlogical.c
- src/bin/pg_basebackup/receivelog.c 11 additions, 11 deletionssrc/bin/pg_basebackup/receivelog.c
- src/bin/pg_basebackup/streamutil.c 9 additions, 11 deletionssrc/bin/pg_basebackup/streamutil.c
- src/bin/pg_basebackup/streamutil.h 4 additions, 3 deletionssrc/bin/pg_basebackup/streamutil.h
- src/include/datatype/timestamp.h 0 additions, 4 deletionssrc/include/datatype/timestamp.h
- src/include/utils/snapmgr.h 4 additions, 3 deletionssrc/include/utils/snapmgr.h
Loading
Please register or sign in to comment