-
- Downloads
Improve index AMs' opclass validation procedures.
The amvalidate functions added in commit 65c5fcd3 were on the crude side. Improve them in a few ways: * Perform signature checking for operators and support functions. * Apply more thorough checks for missing operators and functions, where possible. * Instead of reporting problems as ERRORs, report most problems as INFO messages and make the amvalidate function return FALSE. This allows more than one problem to be discovered per run. * Report object names rather than OIDs, and work a bit harder on making the messages understandable. Also, remove a few more opr_sanity regression test queries that are now superseded by the amvalidate checks.
Showing
- src/backend/access/brin/brin_validate.c 193 additions, 67 deletionssrc/backend/access/brin/brin_validate.c
- src/backend/access/gin/ginvalidate.c 178 additions, 55 deletionssrc/backend/access/gin/ginvalidate.c
- src/backend/access/gist/gistvalidate.c 191 additions, 50 deletionssrc/backend/access/gist/gistvalidate.c
- src/backend/access/hash/hashvalidate.c 222 additions, 67 deletionssrc/backend/access/hash/hashvalidate.c
- src/backend/access/index/Makefile 1 addition, 1 deletionsrc/backend/access/index/Makefile
- src/backend/access/index/amvalidate.c 246 additions, 0 deletionssrc/backend/access/index/amvalidate.c
- src/backend/access/nbtree/nbtvalidate.c 161 additions, 113 deletionssrc/backend/access/nbtree/nbtvalidate.c
- src/backend/access/spgist/spgvalidate.c 163 additions, 48 deletionssrc/backend/access/spgist/spgvalidate.c
- src/backend/utils/cache/lsyscache.c 23 additions, 0 deletionssrc/backend/utils/cache/lsyscache.c
- src/include/access/amvalidate.h 36 additions, 0 deletionssrc/include/access/amvalidate.h
- src/include/utils/lsyscache.h 1 addition, 0 deletionssrc/include/utils/lsyscache.h
- src/test/regress/expected/opr_sanity.out 1 addition, 203 deletionssrc/test/regress/expected/opr_sanity.out
- src/test/regress/sql/opr_sanity.sql 1 addition, 170 deletionssrc/test/regress/sql/opr_sanity.sql
Loading
Please register or sign in to comment