-
- Downloads
Avoid possibly-unsafe use of Windows' FormatMessage() function.
Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag, it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well. Otherwise, if the message contains any %n insertion markers, the function will try to fetch argument strings to substitute --- which we are not passing, possibly leading to a crash. This is exactly analogous to the rule about not giving printf() a format string you're not in control of. Noted and patched by Christian Ullrich. Back-patch to all supported branches.
Showing
- src/backend/libpq/auth.c 3 additions, 1 deletionsrc/backend/libpq/auth.c
- src/backend/port/win32/socket.c 3 additions, 1 deletionsrc/backend/port/win32/socket.c
- src/interfaces/libpq/fe-auth.c 3 additions, 1 deletionsrc/interfaces/libpq/fe-auth.c
- src/port/dirmod.c 6 additions, 2 deletionssrc/port/dirmod.c
Loading
Please register or sign in to comment