Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
postgres-lambda-diff
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jakob Huber
postgres-lambda-diff
Commits
a0d6e29e
Commit
a0d6e29e
authored
21 years ago
by
Tom Lane
Browse files
Options
Downloads
Patches
Plain Diff
Some more de-FastList-ification.
parent
80c6847c
No related branches found
No related tags found
No related merge requests found
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/backend/executor/execQual.c
+16
-21
16 additions, 21 deletions
src/backend/executor/execQual.c
src/backend/parser/gram.y
+3
-8
3 additions, 8 deletions
src/backend/parser/gram.y
src/backend/parser/parse_target.c
+19
-21
19 additions, 21 deletions
src/backend/parser/parse_target.c
with
38 additions
and
50 deletions
src/backend/executor/execQual.c
+
16
−
21
View file @
a0d6e29e
...
...
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.16
1
2004/0
5/30 23:40:26 neilc
Exp $
* $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.16
2
2004/0
6/01 03:28:41 tgl
Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -2826,12 +2826,11 @@ ExecInitExpr(Expr *node, PlanState *parent)
{
CaseExpr
*
caseexpr
=
(
CaseExpr
*
)
node
;
CaseExprState
*
cstate
=
makeNode
(
CaseExprState
);
Fast
List
outlist
;
List
*
outlist
=
NIL
;
ListCell
*
l
;
cstate
->
xprstate
.
evalfunc
=
(
ExprStateEvalFunc
)
ExecEvalCase
;
cstate
->
arg
=
ExecInitExpr
(
caseexpr
->
arg
,
parent
);
FastListInit
(
&
outlist
);
foreach
(
l
,
caseexpr
->
args
)
{
CaseWhen
*
when
=
(
CaseWhen
*
)
lfirst
(
l
);
...
...
@@ -2842,9 +2841,9 @@ ExecInitExpr(Expr *node, PlanState *parent)
wstate
->
xprstate
.
expr
=
(
Expr
*
)
when
;
wstate
->
expr
=
ExecInitExpr
(
when
->
expr
,
parent
);
wstate
->
result
=
ExecInitExpr
(
when
->
result
,
parent
);
FastA
ppend
(
&
outlist
,
wstate
);
outlist
=
la
ppend
(
outlist
,
wstate
);
}
cstate
->
args
=
FastListValue
(
&
outlist
)
;
cstate
->
args
=
outlist
;
cstate
->
defresult
=
ExecInitExpr
(
caseexpr
->
defresult
,
parent
);
state
=
(
ExprState
*
)
cstate
;
}
...
...
@@ -2853,20 +2852,19 @@ ExecInitExpr(Expr *node, PlanState *parent)
{
ArrayExpr
*
arrayexpr
=
(
ArrayExpr
*
)
node
;
ArrayExprState
*
astate
=
makeNode
(
ArrayExprState
);
Fast
List
outlist
;
List
*
outlist
=
NIL
;
ListCell
*
l
;
astate
->
xprstate
.
evalfunc
=
(
ExprStateEvalFunc
)
ExecEvalArray
;
FastListInit
(
&
outlist
);
foreach
(
l
,
arrayexpr
->
elements
)
{
Expr
*
e
=
(
Expr
*
)
lfirst
(
l
);
ExprState
*
estate
;
estate
=
ExecInitExpr
(
e
,
parent
);
FastA
ppend
(
&
outlist
,
estate
);
outlist
=
la
ppend
(
outlist
,
estate
);
}
astate
->
elements
=
FastListValue
(
&
outlist
)
;
astate
->
elements
=
outlist
;
/* do one-time catalog lookup for type info */
get_typlenbyvalalign
(
arrayexpr
->
element_typeid
,
&
astate
->
elemlength
,
...
...
@@ -2879,11 +2877,10 @@ ExecInitExpr(Expr *node, PlanState *parent)
{
RowExpr
*
rowexpr
=
(
RowExpr
*
)
node
;
RowExprState
*
rstate
=
makeNode
(
RowExprState
);
List
*
outlist
;
List
*
outlist
=
NIL
;
ListCell
*
l
;
rstate
->
xprstate
.
evalfunc
=
(
ExprStateEvalFunc
)
ExecEvalRow
;
outlist
=
NIL
;
foreach
(
l
,
rowexpr
->
args
)
{
Expr
*
e
=
(
Expr
*
)
lfirst
(
l
);
...
...
@@ -2912,20 +2909,19 @@ ExecInitExpr(Expr *node, PlanState *parent)
{
CoalesceExpr
*
coalesceexpr
=
(
CoalesceExpr
*
)
node
;
CoalesceExprState
*
cstate
=
makeNode
(
CoalesceExprState
);
Fast
List
outlist
;
List
*
outlist
=
NIL
;
ListCell
*
l
;
cstate
->
xprstate
.
evalfunc
=
(
ExprStateEvalFunc
)
ExecEvalCoalesce
;
FastListInit
(
&
outlist
);
foreach
(
l
,
coalesceexpr
->
args
)
{
Expr
*
e
=
(
Expr
*
)
lfirst
(
l
);
ExprState
*
estate
;
estate
=
ExecInitExpr
(
e
,
parent
);
FastA
ppend
(
&
outlist
,
estate
);
outlist
=
la
ppend
(
outlist
,
estate
);
}
cstate
->
args
=
FastListValue
(
&
outlist
)
;
cstate
->
args
=
outlist
;
state
=
(
ExprState
*
)
cstate
;
}
break
;
...
...
@@ -2984,18 +2980,17 @@ ExecInitExpr(Expr *node, PlanState *parent)
break
;
case
T_List
:
{
Fast
List
outlist
;
List
*
outlist
=
NIL
;
ListCell
*
l
;
FastListInit
(
&
outlist
);
foreach
(
l
,
(
List
*
)
node
)
{
FastA
ppend
(
&
outlist
,
outlist
=
la
ppend
(
outlist
,
ExecInitExpr
((
Expr
*
)
lfirst
(
l
),
parent
));
}
/* Don't fall through to the "common" code below */
return
(
ExprState
*
)
FastListValue
(
&
outlist
)
;
return
(
ExprState
*
)
outlist
;
}
default:
elog
(
ERROR
,
"unrecognized node type: %d"
,
...
...
This diff is collapsed.
Click to expand it.
src/backend/parser/gram.y
+
3
−
8
View file @
a0d6e29e
...
...
@@ -11,7 +11,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.45
8
2004/0
5/30 23:40:34 neilc
Exp $
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.45
9
2004/0
6/01 03:28:48 tgl
Exp $
*
* HISTORY
* AUTHOR DATE MAJOR EVENT
...
...
@@ -108,7 +108,6 @@ static void doNegateFloat(Value *v);
OnCommitAction oncommit;
ContainsOids withoids;
List *list;
FastList fastlist;
Node *node;
Value *value;
ColumnRef *columnref;
...
...
@@ -6820,15 +6819,11 @@ opt_indirection:
expr_list: a_expr
{
FastList *dst = (FastList *) &$$;
makeFastList1(dst, $1);
$$ = list_make1($1);
}
| expr_list ',' a_expr
{
FastList *dst = (FastList *) &$$;
FastList *src = (FastList *) &$1;
*dst = *src;
FastAppend(dst, $3);
$$ = lappend($1, $3);
}
;
...
...
This diff is collapsed.
Click to expand it.
src/backend/parser/parse_target.c
+
19
−
21
View file @
a0d6e29e
...
...
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/parser/parse_target.c,v 1.1
19
2004/0
5/30 23:40:35 neilc
Exp $
* $PostgreSQL: pgsql/src/backend/parser/parse_target.c,v 1.1
20
2004/0
6/01 03:28:48 tgl
Exp $
*
*-------------------------------------------------------------------------
*/
...
...
@@ -92,11 +92,9 @@ transformTargetEntry(ParseState *pstate,
List
*
transformTargetList
(
ParseState
*
pstate
,
List
*
targetlist
)
{
Fast
List
p_target
;
List
*
p_target
=
NIL
;
ListCell
*
o_target
;
FastListInit
(
&
p_target
);
foreach
(
o_target
,
targetlist
)
{
ResTarget
*
res
=
(
ResTarget
*
)
lfirst
(
o_target
);
...
...
@@ -116,7 +114,7 @@ transformTargetList(ParseState *pstate, List *targetlist)
* Target item is a single '*', expand all tables
* (e.g., SELECT * FROM emp)
*/
FastConc
(
&
p_target
,
p_target
=
list_concat
(
p_target
,
ExpandAllTables
(
pstate
));
}
else
...
...
@@ -173,14 +171,14 @@ transformTargetList(ParseState *pstate, List *targetlist)
rte
=
addImplicitRTE
(
pstate
,
makeRangeVar
(
schemaname
,
relname
));
FastConc
(
&
p_target
,
p_target
=
list_concat
(
p_target
,
expandRelAttrs
(
pstate
,
rte
));
}
}
else
{
/* Plain ColumnRef node, treat it as an expression */
FastA
ppend
(
&
p_target
,
p_target
=
la
ppend
(
p_target
,
transformTargetEntry
(
pstate
,
res
->
val
,
NULL
,
...
...
@@ -191,7 +189,7 @@ transformTargetList(ParseState *pstate, List *targetlist)
else
{
/* Everything else but ColumnRef */
FastA
ppend
(
&
p_target
,
p_target
=
la
ppend
(
p_target
,
transformTargetEntry
(
pstate
,
res
->
val
,
NULL
,
...
...
@@ -200,7 +198,7 @@ transformTargetList(ParseState *pstate, List *targetlist)
}
}
return
FastListValue
(
&
p_target
)
;
return
p_target
;
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment