-
- Downloads
Install a "dead man switch" to allow the postmaster to detect cases where
a backend has done exit(0) or exit(1) without having disengaged itself from shared memory. We are at risk for this whenever third-party code is loaded into a backend, since such code might not know it's supposed to go through proc_exit() instead. Also, it is reported that under Windows there are ways to externally kill a process that cause the status code returned to the postmaster to be indistinguishable from a voluntary exit (thank you, Microsoft). If this does happen then the system is probably hosed --- for instance, the dead session might still be holding locks. So the best recovery method is to treat this like a backend crash. The dead man switch is armed for a particular child process when it acquires a regular PGPROC, and disarmed when the PGPROC is released; these should be the first and last touches of shared memory resources in a backend, or close enough anyway. This choice means there is no coverage for auxiliary processes, but I doubt we need that, since they shouldn't be executing any user-provided code anyway. This patch also improves the management of the EXEC_BACKEND ShmemBackendArray array a bit, by reducing search costs. Although this problem is of long standing, the lack of field complaints seems to mean it's not critical enough to risk back-patching; at least not till we get some more testing of this mechanism.
Showing
- src/backend/postmaster/postmaster.c 97 additions, 72 deletionssrc/backend/postmaster/postmaster.c
- src/backend/storage/ipc/ipci.c 3 additions, 2 deletionssrc/backend/storage/ipc/ipci.c
- src/backend/storage/ipc/pmsignal.c 146 additions, 12 deletionssrc/backend/storage/ipc/pmsignal.c
- src/backend/storage/lmgr/proc.c 17 additions, 1 deletionsrc/backend/storage/lmgr/proc.c
- src/backend/utils/init/globals.c 2 additions, 1 deletionsrc/backend/utils/init/globals.c
- src/include/miscadmin.h 2 additions, 1 deletionsrc/include/miscadmin.h
- src/include/postmaster/postmaster.h 3 additions, 1 deletionsrc/include/postmaster/postmaster.h
- src/include/storage/pmsignal.h 10 additions, 2 deletionssrc/include/storage/pmsignal.h
Loading
Please register or sign in to comment