Code review for palloc0 patch --- avoid dangerous and unnecessary
practice of evaluating MemSet's arguments multiple times, except for the special case of newNode(), where we can assume the argument is a constant sizeof() operator. Also, add GetMemoryChunkContext() to mcxt.c's API, in preparation for fixing recent GEQO breakage.
Showing
- src/backend/nodes/nodes.c 4 additions, 9 deletionssrc/backend/nodes/nodes.c
- src/backend/utils/mmgr/mcxt.c 61 additions, 5 deletionssrc/backend/utils/mmgr/mcxt.c
- src/include/c.h 65 additions, 25 deletionssrc/include/c.h
- src/include/nodes/nodes.h 11 additions, 5 deletionssrc/include/nodes/nodes.h
- src/include/utils/memutils.h 2 additions, 1 deletionsrc/include/utils/memutils.h
- src/include/utils/palloc.h 17 additions, 7 deletionssrc/include/utils/palloc.h
Loading
Please register or sign in to comment