Create an improved FDW option validator function for contrib/dblink.
dblink now has its own validator function dblink_fdw_validator(), which is better than the core function postgresql_fdw_validator() because it gets the list of legal options from libpq instead of having a hard-wired list. Make the dblink extension module provide a standard foreign data wrapper dblink_fdw that encapsulates use of this validator, and recommend use of that wrapper instead of making up wrappers on the fly. Unfortunately, because ad-hoc wrappers *were* recommended practice previously, it's not clear when we can get rid of postgresql_fdw_validator without causing upgrade problems. But this is a step in the right direction. Shigeru Hanada, reviewed by KaiGai Kohei
Showing
- contrib/dblink/Makefile 1 addition, 1 deletioncontrib/dblink/Makefile
- contrib/dblink/dblink--1.0--1.1.sql 14 additions, 0 deletionscontrib/dblink/dblink--1.0--1.1.sql
- contrib/dblink/dblink--1.1.sql 13 additions, 1 deletioncontrib/dblink/dblink--1.1.sql
- contrib/dblink/dblink.c 130 additions, 0 deletionscontrib/dblink/dblink.c
- contrib/dblink/dblink.control 1 addition, 1 deletioncontrib/dblink/dblink.control
- contrib/dblink/dblink.h 1 addition, 0 deletionscontrib/dblink/dblink.h
- contrib/dblink/expected/dblink.out 14 additions, 3 deletionscontrib/dblink/expected/dblink.out
- contrib/dblink/sql/dblink.sql 10 additions, 3 deletionscontrib/dblink/sql/dblink.sql
- doc/src/sgml/dblink.sgml 4 additions, 8 deletionsdoc/src/sgml/dblink.sgml
Loading
Please register or sign in to comment