-
- Downloads
Repair logic for reordering grouping sets optimization.
The logic in reorder_grouping_sets to order grouping set elements to match a pre-specified sort ordering was defective, resulting in unnecessary sort nodes (though the query output would still be correct). Repair, simplifying the code a little, and add a test. Per report from Richard Guo, though I didn't use their patch. Original bug seems to have been my fault. Backpatch back to 9.5 where grouping sets were introduced. Discussion: https://postgr.es/m/CAN_9JTzyjGcUjiBHxLsgqfk7PkdLGXiM=pwM+=ph2LsWw0WO1A@mail.gmail.com
Showing
- src/backend/optimizer/plan/planner.c 18 additions, 21 deletionssrc/backend/optimizer/plan/planner.c
- src/test/regress/expected/groupingsets.out 13 additions, 0 deletionssrc/test/regress/expected/groupingsets.out
- src/test/regress/sql/groupingsets.sql 3 additions, 0 deletionssrc/test/regress/sql/groupingsets.sql
Loading
Please register or sign in to comment