-
- Downloads
Fix "unexpected relkind" error when denying permissions on toast tables.
get_relkind_objtype, and hence get_object_type, failed when applied to a toast table. This is not a good thing, because it prevents reporting of perfectly legitimate permissions errors. (At present, these functions are in fact *only* used to determine the ObjectType argument for acl_error() calls.) It seems best to have them fall back to returning OBJECT_TABLE in every case where they can't determine an object type for a pg_class entry, so do that. In passing, make some edits to alter.c to make it more obvious that those calls of get_object_type() are used only for error reporting. This might save a few cycles in the non-error code path, too. Back-patch to v11 where this issue originated. John Hsu, Michael Paquier, Tom Lane Discussion: https://postgr.es/m/C652D3DF-2B0C-4128-9420-FB5379F6B1E4@amazon.com
Showing
- src/backend/catalog/objectaddress.c 21 additions, 7 deletionssrc/backend/catalog/objectaddress.c
- src/backend/commands/alter.c 5 additions, 7 deletionssrc/backend/commands/alter.c
- src/test/regress/expected/create_index.out 9 additions, 0 deletionssrc/test/regress/expected/create_index.out
- src/test/regress/sql/create_index.sql 7 additions, 0 deletionssrc/test/regress/sql/create_index.sql
Loading
Please register or sign in to comment