-
- Downloads
Prefer pg_any_to_server/pg_server_to_any over pg_do_encoding_conversion.
A large majority of the callers of pg_do_encoding_conversion were specifying the database encoding as either source or target of the conversion, meaning that we can use the less general functions pg_any_to_server/pg_server_to_any instead. The main advantage of using the latter functions is that they can make use of a cached conversion-function lookup in the common case that the other encoding is the current client_encoding. It's notationally cleaner too in most cases, not least because of the historical artifact that the latter functions use "char *" rather than "unsigned char *" in their APIs. Note that pg_any_to_server will apply an encoding verification step in some cases where pg_do_encoding_conversion would have just done nothing. This seems to me to be a good idea at most of these call sites, though it partially negates the performance benefit. Per discussion of bug #9210.
Showing
- contrib/pg_stat_statements/pg_stat_statements.c 3 additions, 5 deletionscontrib/pg_stat_statements/pg_stat_statements.c
- contrib/sslinfo/sslinfo.c 2 additions, 8 deletionscontrib/sslinfo/sslinfo.c
- src/backend/commands/extension.c 2 additions, 6 deletionssrc/backend/commands/extension.c
- src/backend/snowball/dict_snowball.c 2 additions, 8 deletionssrc/backend/snowball/dict_snowball.c
- src/backend/tsearch/ts_locale.c 1 addition, 4 deletionssrc/backend/tsearch/ts_locale.c
- src/backend/utils/adt/pg_locale.c 9 additions, 14 deletionssrc/backend/utils/adt/pg_locale.c
- src/backend/utils/adt/xml.c 9 additions, 18 deletionssrc/backend/utils/adt/xml.c
- src/backend/utils/mb/mbutils.c 3 additions, 1 deletionsrc/backend/utils/mb/mbutils.c
- src/pl/plperl/plperl.c 2 additions, 6 deletionssrc/pl/plperl/plperl.c
- src/pl/plperl/plperl_helpers.h 7 additions, 18 deletionssrc/pl/plperl/plperl_helpers.h
- src/pl/plpython/plpy_util.c 5 additions, 10 deletionssrc/pl/plpython/plpy_util.c
- src/pl/tcl/pltcl.c 6 additions, 2 deletionssrc/pl/tcl/pltcl.c
Loading
Please register or sign in to comment