-
- Downloads
Further code review for pg_lsn data type.
Change input function error messages to be more consistent with what is done elsewhere. Remove a bunch of redundant type casts, so that the compiler will warn us if we screw up. Don't pass LSNs by value on platforms where a Datum is only 32 bytes, per buildfarm. Move macros for packing and unpacking LSNs to pg_lsn.h so that we can include access/xlogdefs.h, to avoid an unsatisfied dependency on XLogRecPtr.
Showing
- src/backend/utils/adt/pg_lsn.c 19 additions, 19 deletionssrc/backend/utils/adt/pg_lsn.c
- src/include/catalog/pg_type.h 1 addition, 1 deletionsrc/include/catalog/pg_type.h
- src/include/fmgr.h 0 additions, 2 deletionssrc/include/fmgr.h
- src/include/postgres.h 0 additions, 14 deletionssrc/include/postgres.h
- src/include/utils/pg_lsn.h 7 additions, 0 deletionssrc/include/utils/pg_lsn.h
- src/test/regress/expected/pg_lsn.out 5 additions, 5 deletionssrc/test/regress/expected/pg_lsn.out
Loading
Please register or sign in to comment