-
- Downloads
Improve code around the recently added rm_identify rmgr callback.
There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2: * append_init() in heapdesc.c was ugly and required that rm_identify return values are only valid till the next call. Instead just add a couple more switch() cases for the INIT_PAGE cases. Now the returned value will always be valid. * a couple rm_identify() callbacks missed masking xl_info with ~XLR_INFO_MASK. * pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar string. * append_init() was called when id=NULL - which should never actually happen. But it's better to be careful.
Showing
- contrib/pg_xlogdump/pg_xlogdump.c 6 additions, 1 deletioncontrib/pg_xlogdump/pg_xlogdump.c
- src/backend/access/rmgrdesc/clogdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/clogdesc.c
- src/backend/access/rmgrdesc/dbasedesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/dbasedesc.c
- src/backend/access/rmgrdesc/gindesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/gindesc.c
- src/backend/access/rmgrdesc/gistdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/gistdesc.c
- src/backend/access/rmgrdesc/heapdesc.c 14 additions, 19 deletionssrc/backend/access/rmgrdesc/heapdesc.c
- src/backend/access/rmgrdesc/mxactdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/mxactdesc.c
- src/backend/access/rmgrdesc/nbtdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/nbtdesc.c
- src/backend/access/rmgrdesc/relmapdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/relmapdesc.c
- src/backend/access/rmgrdesc/seqdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/seqdesc.c
- src/backend/access/rmgrdesc/smgrdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/smgrdesc.c
- src/backend/access/rmgrdesc/spgdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/spgdesc.c
- src/backend/access/rmgrdesc/standbydesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/standbydesc.c
- src/backend/access/rmgrdesc/tblspcdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/tblspcdesc.c
- src/backend/access/rmgrdesc/xactdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/xactdesc.c
- src/backend/access/rmgrdesc/xlogdesc.c 1 addition, 1 deletionsrc/backend/access/rmgrdesc/xlogdesc.c
- src/backend/access/transam/xlog.c 2 additions, 1 deletionsrc/backend/access/transam/xlog.c
- src/include/access/xlog_internal.h 0 additions, 3 deletionssrc/include/access/xlog_internal.h
Loading
Please register or sign in to comment