-
- Downloads
Avoid having two copies of the HOT-chain search logic.
It's been like this since HOT was originally introduced, but the logic is complex enough that this is a recipe for bugs, as we've already found out with SSI. So refactor heap_hot_search_buffer() so that it can satisfy the needs of index_getnext(), and make index_getnext() use that rather than duplicating the logic. This change was originally proposed by Heikki Linnakangas as part of a larger refactoring oriented towards allowing index-only scans. I extracted and adjusted this part, since it seems to have independent merit. Review by Jeff Davis.
Showing
- src/backend/access/heap/heapam.c 46 additions, 26 deletionssrc/backend/access/heap/heapam.c
- src/backend/access/index/genam.c 1 addition, 3 deletionssrc/backend/access/index/genam.c
- src/backend/access/index/indexam.c 21 additions, 153 deletionssrc/backend/access/index/indexam.c
- src/backend/executor/nodeBitmapHeapscan.c 3 additions, 1 deletionsrc/backend/executor/nodeBitmapHeapscan.c
- src/include/access/heapam.h 2 additions, 1 deletionsrc/include/access/heapam.h
- src/include/access/relscan.h 1 addition, 3 deletionssrc/include/access/relscan.h
Loading
Please register or sign in to comment