-
- Downloads
Fix ON CONFLICT bugs that manifest when used in rules.
Specifically the tlist and rti of the pseudo "excluded" relation weren't properly treated by expression_tree_walker, which lead to errors when excluded was referenced inside a rule because the varnos where not properly adjusted. Similar omissions in OffsetVarNodes and expression_tree_mutator had less impact, but should obviously be fixed nonetheless. A couple tests of for ON CONFLICT UPDATE into INSERT rule bearing relations have been added. In passing I updated a couple comments.
Showing
- src/backend/executor/nodeModifyTable.c 1 addition, 0 deletionssrc/backend/executor/nodeModifyTable.c
- src/backend/nodes/nodeFuncs.c 3 additions, 0 deletionssrc/backend/nodes/nodeFuncs.c
- src/backend/optimizer/plan/setrefs.c 6 additions, 3 deletionssrc/backend/optimizer/plan/setrefs.c
- src/backend/rewrite/rewriteManip.c 12 additions, 3 deletionssrc/backend/rewrite/rewriteManip.c
- src/test/regress/expected/rules.out 96 additions, 9 deletionssrc/test/regress/expected/rules.out
- src/test/regress/sql/rules.sql 33 additions, 2 deletionssrc/test/regress/sql/rules.sql
Loading
Please register or sign in to comment