When FOR UPDATE/SHARE is used with LIMIT, put the LockRows plan node
underneath the Limit node, not atop it. This fixes the old problem that such a query might unexpectedly return fewer rows than the LIMIT says, due to LockRows discarding updated rows. There is a related problem that LockRows might destroy the sort ordering produced by earlier steps; but fixing that by pushing LockRows below Sort would create serious performance problems that are unjustified in many real-world applications, as well as potential deadlock problems from locking many more rows than expected. Instead, keep the present semantics of applying FOR UPDATE after ORDER BY within a single query level; but allow the user to specify the other way by writing FOR UPDATE in a sub-select. To make that work, track whether FOR UPDATE appeared explicitly in sub-selects or got pushed down from the parent, and don't flatten a sub-select that contained an explicit FOR UPDATE.
Showing
- doc/src/sgml/ref/select.sgml 83 additions, 41 deletionsdoc/src/sgml/ref/select.sgml
- src/backend/nodes/copyfuncs.c 3 additions, 1 deletionsrc/backend/nodes/copyfuncs.c
- src/backend/nodes/equalfuncs.c 3 additions, 1 deletionsrc/backend/nodes/equalfuncs.c
- src/backend/nodes/outfuncs.c 3 additions, 1 deletionsrc/backend/nodes/outfuncs.c
- src/backend/nodes/readfuncs.c 3 additions, 1 deletionsrc/backend/nodes/readfuncs.c
- src/backend/optimizer/plan/planner.c 37 additions, 20 deletionssrc/backend/optimizer/plan/planner.c
- src/backend/optimizer/prep/prepjointree.c 8 additions, 1 deletionsrc/backend/optimizer/prep/prepjointree.c
- src/backend/parser/analyze.c 37 additions, 18 deletionssrc/backend/parser/analyze.c
- src/backend/rewrite/rewriteHandler.c 14 additions, 22 deletionssrc/backend/rewrite/rewriteHandler.c
- src/backend/utils/adt/ruleutils.c 21 additions, 14 deletionssrc/backend/utils/adt/ruleutils.c
- src/include/catalog/catversion.h 2 additions, 2 deletionssrc/include/catalog/catversion.h
- src/include/nodes/parsenodes.h 9 additions, 2 deletionssrc/include/nodes/parsenodes.h
- src/include/parser/analyze.h 2 additions, 2 deletionssrc/include/parser/analyze.h
Loading
Please register or sign in to comment