check socket creation errors against PGINVALID_SOCKET
Previously, in some places, socket creation errors were checked for negative values, which is not true for Windows because sockets are unsigned. This masked socket creation errors on Windows. Backpatch through 9.0. 8.4 doesn't have the infrastructure to fix this.
Showing
- src/backend/libpq/auth.c 3 additions, 3 deletionssrc/backend/libpq/auth.c
- src/backend/libpq/ip.c 5 additions, 5 deletionssrc/backend/libpq/ip.c
- src/backend/libpq/pqcomm.c 2 additions, 2 deletionssrc/backend/libpq/pqcomm.c
- src/backend/port/win32/socket.c 1 addition, 1 deletionsrc/backend/port/win32/socket.c
- src/backend/postmaster/postmaster.c 1 addition, 1 deletionsrc/backend/postmaster/postmaster.c
- src/interfaces/libpq/fe-connect.c 29 additions, 5 deletionssrc/interfaces/libpq/fe-connect.c
- src/interfaces/libpq/libpq-int.h 1 addition, 0 deletionssrc/interfaces/libpq/libpq-int.h
Loading
Please register or sign in to comment