Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
postgres-lambda-diff
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jakob Huber
postgres-lambda-diff
Commits
2e54d88a
Commit
2e54d88a
authored
11 years ago
by
Simon Riggs
Browse files
Options
Downloads
Patches
Plain Diff
Correct comment in Hot Standby nbtree handling
Logic is correct, matching handling of LP_DEAD elsewhere.
parent
284c464b
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/backend/access/nbtree/nbtxlog.c
+5
-5
5 additions, 5 deletions
src/backend/access/nbtree/nbtxlog.c
with
5 additions
and
5 deletions
src/backend/access/nbtree/nbtxlog.c
+
5
−
5
View file @
2e54d88a
...
...
@@ -714,11 +714,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
UnlockReleaseBuffer
(
ibuffer
);
/*
*
XXX
If all heap tuples were LP_DEAD then we will be returning
* InvalidTransactionId here,
causing conflict for all HS transactions.
*
That should happen very rarely (reasoning please?). Also note that
*
caller can't tell the difference between this case and the fast p
at
h
*
exit above. May need to change that in future
.
* If all heap tuples were LP_DEAD then we will be returning
* InvalidTransactionId here,
which avoids conflicts. This matches
*
existing logic which assumes that LP_DEAD tuples must already be
*
older than the latestRemovedXid on the cleanup record th
at
*
set them as LP_DEAD, hence must already have generated a conflict
.
*/
return
latestRemovedXid
;
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment