-
- Downloads
Fix race condition in relcache init file invalidation.
The previous code tried to synchronize by unlinking the init file twice, but that doesn't actually work: it leaves a window wherein a third process could read the already-stale init file but miss the SI messages that would tell it the data is stale. The result would be bizarre failures in catalog accesses, typically "could not read block 0 in file ..." later during startup. Instead, hold RelCacheInitLock across both the unlink and the sending of the SI messages. This is more straightforward, and might even be a bit faster since only one unlink call is needed. This has been wrong since it was put in (in 2002!), so back-patch to all supported releases.
Showing
- src/backend/access/transam/twophase.c 2 additions, 2 deletionssrc/backend/access/transam/twophase.c
- src/backend/utils/cache/inval.c 17 additions, 16 deletionssrc/backend/utils/cache/inval.c
- src/backend/utils/cache/relcache.c 36 additions, 30 deletionssrc/backend/utils/cache/relcache.c
- src/include/utils/relcache.h 2 additions, 1 deletionsrc/include/utils/relcache.h
Loading
Please register or sign in to comment