Commit Karel's patch.
------------------------------------------------------------------- Subject: Re: [PATCHES] encoding names From: Karel Zak <zakkr@zf.jcu.cz> To: Peter Eisentraut <peter_e@gmx.net> Cc: pgsql-patches <pgsql-patches@postgresql.org> Date: Fri, 31 Aug 2001 17:24:38 +0200 On Thu, Aug 30, 2001 at 01:30:40AM +0200, Peter Eisentraut wrote: > > - convert encoding 'name' to 'id' > > I thought we decided not to add functions returning "new" names until we > know exactly what the new names should be, and pending schema Ok, the patch not to add functions. > better > > ...(): encoding name too long Fixed. I found new bug in command/variable.c in parse_client_encoding(), nobody probably never see this error: if (pg_set_client_encoding(encoding)) { elog(ERROR, "Conversion between %s and %s is not supported", value, GetDatabaseEncodingName()); } because pg_set_client_encoding() returns -1 for error and 0 as true. It's fixed too. IMHO it can be apply. Karel PS: * following files are renamed: src/utils/mb/Unicode/KOI8_to_utf8.map --> src/utils/mb/Unicode/koi8r_to_utf8.map src/utils/mb/Unicode/WIN_to_utf8.map --> src/utils/mb/Unicode/win1251_to_utf8.map src/utils/mb/Unicode/utf8_to_KOI8.map --> src/utils/mb/Unicode/utf8_to_koi8r.map src/utils/mb/Unicode/utf8_to_WIN.map --> src/utils/mb/Unicode/utf8_to_win1251.map * new file: src/utils/mb/encname.c * removed file: src/utils/mb/common.c -- Karel Zak <zakkr@zf.jcu.cz> http://home.zf.jcu.cz/~zakkr/ C, PostgreSQL, PHP, WWW, http://docs.linux.cz, http://mape.jcu.cz
Showing
- src/backend/commands/dbcommands.c 12 additions, 1 deletionsrc/backend/commands/dbcommands.c
- src/backend/commands/variable.c 8 additions, 9 deletionssrc/backend/commands/variable.c
- src/backend/parser/gram.y 3 additions, 3 deletionssrc/backend/parser/gram.y
- src/backend/utils/adt/ascii.c 4 additions, 4 deletionssrc/backend/utils/adt/ascii.c
- src/backend/utils/init/postinit.c 2 additions, 2 deletionssrc/backend/utils/init/postinit.c
- src/backend/utils/mb/Makefile 4 additions, 4 deletionssrc/backend/utils/mb/Makefile
- src/backend/utils/mb/Unicode/Makefile 3 additions, 3 deletionssrc/backend/utils/mb/Unicode/Makefile
- src/backend/utils/mb/Unicode/UCS_to_cyrillic.pl 4 additions, 4 deletionssrc/backend/utils/mb/Unicode/UCS_to_cyrillic.pl
- src/backend/utils/mb/conv.c 86 additions, 114 deletionssrc/backend/utils/mb/conv.c
- src/backend/utils/mb/mbutils.c 91 additions, 45 deletionssrc/backend/utils/mb/mbutils.c
- src/backend/utils/mb/wchar.c 32 additions, 38 deletionssrc/backend/utils/mb/wchar.c
- src/bin/initdb/initdb.sh 3 additions, 7 deletionssrc/bin/initdb/initdb.sh
- src/bin/pg_encoding/pg_encoding.c 52 additions, 14 deletionssrc/bin/pg_encoding/pg_encoding.c
- src/bin/scripts/createdb 1 addition, 5 deletionssrc/bin/scripts/createdb
- src/include/catalog/pg_proc.h 3 additions, 1 deletionsrc/include/catalog/pg_proc.h
- src/include/mb/pg_wchar.h 148 additions, 67 deletionssrc/include/mb/pg_wchar.h
- src/include/utils/builtins.h 4 additions, 1 deletionsrc/include/utils/builtins.h
- src/interfaces/libpq/Makefile 5 additions, 3 deletionssrc/interfaces/libpq/Makefile
- src/interfaces/libpq/fe-connect.c 4 additions, 73 deletionssrc/interfaces/libpq/fe-connect.c
- src/interfaces/libpq/fe-misc.c 2 additions, 2 deletionssrc/interfaces/libpq/fe-misc.c
Loading
Please register or sign in to comment