-
- Downloads
Allow empty target list in SELECT.
This fixes a problem noted as a followup to bug #8648: if a query has a semantically-empty target list, e.g. SELECT * FROM zero_column_table, ruleutils.c will dump it as a syntactically-empty target list, which was not allowed. There doesn't seem to be any reliable way to fix this by hacking ruleutils (note in particular that the originally zero-column table might since have had columns added to it); and even if we had such a fix, it would do nothing for existing dump files that might contain bad syntax. The best bet seems to be to relax the syntactic restriction. Also, add parse-analysis errors for SELECT DISTINCT with no columns (after *-expansion) and RETURNING with no columns. These cases previously produced unexpected behavior because the parsed Query looked like it had no DISTINCT or RETURNING clause, respectively. If anyone ever offers a plausible use-case for this, we could work a bit harder on making the situation distinguishable. Arguably this is a bug fix that should be back-patched, but I'm worried that there may be client apps or PLs that expect "SELECT ;" to throw a syntax error. The issue doesn't seem important enough to risk changing behavior in minor releases.
Showing
- doc/src/sgml/ref/select.sgml 21 additions, 7 deletionsdoc/src/sgml/ref/select.sgml
- src/backend/parser/analyze.c 13 additions, 0 deletionssrc/backend/parser/analyze.c
- src/backend/parser/gram.y 6 additions, 2 deletionssrc/backend/parser/gram.y
- src/backend/parser/parse_clause.c 19 additions, 0 deletionssrc/backend/parser/parse_clause.c
- src/test/regress/expected/errors.out 8 additions, 15 deletionssrc/test/regress/expected/errors.out
- src/test/regress/sql/errors.sql 6 additions, 9 deletionssrc/test/regress/sql/errors.sql
Loading
Please register or sign in to comment