-
- Downloads
Select CFLAGS_SL at configure time, not in platform-specific Makefiles.
Move the platform-dependent logic that sets CFLAGS_SL from src/makefiles/Makefile.foo to src/template/foo, so that the value is determined at configure time and thus is available while running configure's tests. On a couple of platforms this might save a few microseconds of build time by eliminating a test that make otherwise has to do over and over. Otherwise it's pretty much a wash for build purposes; in particular, this makes no difference to anyone who might be overriding CFLAGS_SL via a make option. This patch in itself does nothing with the value and thus should not change any behavior, though you'll probably have to re-run configure to get a correctly updated Makefile.global. We'll use the new configure variable in a follow-on patch. Per gripe from Kyotaro Horiguchi. Back-patch to all supported branches, because the follow-on patch is a portability bug fix. Discussion: https://postgr.es/m/20191010.144533.263180400.horikyota.ntt@gmail.com
Showing
- configure 4 additions, 1 deletionconfigure
- configure.in 4 additions, 1 deletionconfigure.in
- src/Makefile.global.in 1 addition, 0 deletionssrc/Makefile.global.in
- src/makefiles/Makefile.cygwin 0 additions, 1 deletionsrc/makefiles/Makefile.cygwin
- src/makefiles/Makefile.freebsd 0 additions, 2 deletionssrc/makefiles/Makefile.freebsd
- src/makefiles/Makefile.hpux 0 additions, 5 deletionssrc/makefiles/Makefile.hpux
- src/makefiles/Makefile.linux 0 additions, 2 deletionssrc/makefiles/Makefile.linux
- src/makefiles/Makefile.netbsd 0 additions, 2 deletionssrc/makefiles/Makefile.netbsd
- src/makefiles/Makefile.openbsd 0 additions, 2 deletionssrc/makefiles/Makefile.openbsd
- src/makefiles/Makefile.sco 1 addition, 5 deletionssrc/makefiles/Makefile.sco
- src/makefiles/Makefile.solaris 1 addition, 5 deletionssrc/makefiles/Makefile.solaris
- src/makefiles/Makefile.unixware 1 addition, 5 deletionssrc/makefiles/Makefile.unixware
- src/makefiles/Makefile.win32 0 additions, 1 deletionsrc/makefiles/Makefile.win32
- src/template/aix 5 additions, 0 deletionssrc/template/aix
- src/template/cygwin 3 additions, 0 deletionssrc/template/cygwin
- src/template/darwin 3 additions, 0 deletionssrc/template/darwin
- src/template/freebsd 3 additions, 0 deletionssrc/template/freebsd
- src/template/hpux 7 additions, 0 deletionssrc/template/hpux
- src/template/linux 3 additions, 0 deletionssrc/template/linux
- src/template/netbsd 3 additions, 0 deletionssrc/template/netbsd
Loading
Please register or sign in to comment