pg_dump: Reduce use of global variables
Most pg_dump.c global variables, which were passed down individually to dumping routines, are now grouped as members of the new DumpOptions struct, which is used as a local variable and passed down into routines that need it. This helps future development efforts; in particular it is said to enable a mode in which a parallel pg_dump run can output multiple streams, and have them restored in parallel. Also take the opportunity to clean up the pg_dump header files somewhat, to avoid circularity. Author: Joachim Wieland, revised by Álvaro Herrera Reviewed by Peter Eisentraut
Showing
- src/bin/pg_dump/common.c 15 additions, 12 deletionssrc/bin/pg_dump/common.c
- src/bin/pg_dump/compress_io.c 2 additions, 1 deletionsrc/bin/pg_dump/compress_io.c
- src/bin/pg_dump/compress_io.h 0 additions, 1 deletionsrc/bin/pg_dump/compress_io.h
- src/bin/pg_dump/dumputils.h 18 additions, 1 deletionsrc/bin/pg_dump/dumputils.h
- src/bin/pg_dump/parallel.c 10 additions, 8 deletionssrc/bin/pg_dump/parallel.c
- src/bin/pg_dump/parallel.h 12 additions, 18 deletionssrc/bin/pg_dump/parallel.h
- src/bin/pg_dump/pg_backup.h 88 additions, 22 deletionssrc/bin/pg_dump/pg_backup.h
- src/bin/pg_dump/pg_backup_archiver.c 74 additions, 17 deletionssrc/bin/pg_dump/pg_backup_archiver.c
- src/bin/pg_dump/pg_backup_archiver.h 40 additions, 43 deletionssrc/bin/pg_dump/pg_backup_archiver.h
- src/bin/pg_dump/pg_backup_custom.c 5 additions, 4 deletionssrc/bin/pg_dump/pg_backup_custom.c
- src/bin/pg_dump/pg_backup_db.c 17 additions, 8 deletionssrc/bin/pg_dump/pg_backup_db.c
- src/bin/pg_dump/pg_backup_db.h 6 additions, 5 deletionssrc/bin/pg_dump/pg_backup_db.h
- src/bin/pg_dump/pg_backup_directory.c 9 additions, 8 deletionssrc/bin/pg_dump/pg_backup_directory.c
- src/bin/pg_dump/pg_backup_null.c 8 additions, 6 deletionssrc/bin/pg_dump/pg_backup_null.c
- src/bin/pg_dump/pg_backup_tar.c 4 additions, 5 deletionssrc/bin/pg_dump/pg_backup_tar.c
- src/bin/pg_dump/pg_backup_utils.c 0 additions, 1 deletionsrc/bin/pg_dump/pg_backup_utils.c
- src/bin/pg_dump/pg_backup_utils.h 4 additions, 0 deletionssrc/bin/pg_dump/pg_backup_utils.h
- src/bin/pg_dump/pg_dump.c 424 additions, 449 deletionssrc/bin/pg_dump/pg_dump.c
- src/bin/pg_dump/pg_dump.h 15 additions, 62 deletionssrc/bin/pg_dump/pg_dump.h
- src/bin/pg_dump/pg_dump_sort.c 3 additions, 1 deletionsrc/bin/pg_dump/pg_dump_sort.c
Loading
Please register or sign in to comment