This patch...
1. Removes the unnecessary "#define AbcRegProcedure 123"'s from pg_proc.h. 2. Changes those #defines to use the names already defined in fmgr.h. 3. Forces the make of fmgr.h in backend/Makefile instead of having it made as a dependency in access/common/Makefile *hack*hack*hack* 4. Rearranged the #includes to a less helter-skelter arrangement, also changing <file.h> to "file.h" to signify a non-system header. 5. Removed "pg_proc.h" from files where its only purpose was for the #defines removed in item #1. 6. Added "fmgr.h" to each file changed for completeness sake. Turns out that #6 was not necessary for some files because fmgr.h was being included in a roundabout way SIX levels deep by the first include. "access/genam.h" ->"access/relscan.h" ->"utils/rel.h" ->"access/strat.h" ->"access/skey.h" ->"fmgr.h" So adding fmgr.h really didn't add anything to the compile, hopefully just made it clearer to the programmer. S Darren.
Showing
- src/backend/Makefile 2 additions, 2 deletionssrc/backend/Makefile
- src/backend/access/index/istrat.c 17 additions, 18 deletionssrc/backend/access/index/istrat.c
- src/backend/access/nbtree/nbtutils.c 10 additions, 11 deletionssrc/backend/access/nbtree/nbtutils.c
- src/backend/catalog/aclchk.c 10 additions, 11 deletionssrc/backend/catalog/aclchk.c
- src/backend/catalog/heap.c 38 additions, 38 deletionssrc/backend/catalog/heap.c
- src/backend/catalog/index.c 9 additions, 9 deletionssrc/backend/catalog/index.c
- src/backend/catalog/indexing.c 27 additions, 26 deletionssrc/backend/catalog/indexing.c
- src/backend/catalog/pg_operator.c 30 additions, 29 deletionssrc/backend/catalog/pg_operator.c
- src/backend/catalog/pg_proc.c 22 additions, 21 deletionssrc/backend/catalog/pg_proc.c
- src/backend/catalog/pg_type.c 22 additions, 22 deletionssrc/backend/catalog/pg_type.c
- src/backend/commands/async.c 23 additions, 24 deletionssrc/backend/commands/async.c
- src/backend/commands/command.c 22 additions, 22 deletionssrc/backend/commands/command.c
- src/backend/commands/dbcommands.c 10 additions, 10 deletionssrc/backend/commands/dbcommands.c
- src/backend/commands/proclang.c 5 additions, 4 deletionssrc/backend/commands/proclang.c
- src/backend/commands/remove.c 29 additions, 28 deletionssrc/backend/commands/remove.c
- src/backend/commands/trigger.c 13 additions, 12 deletionssrc/backend/commands/trigger.c
- src/backend/commands/vacuum.c 36 additions, 37 deletionssrc/backend/commands/vacuum.c
- src/backend/executor/execQual.c 13 additions, 16 deletionssrc/backend/executor/execQual.c
- src/backend/executor/execUtils.c 12 additions, 14 deletionssrc/backend/executor/execUtils.c
- src/backend/optimizer/path/clausesel.c 7 additions, 11 deletionssrc/backend/optimizer/path/clausesel.c
Loading
Please register or sign in to comment