Skip to content
Snippets Groups Projects
Select Git revision
  • benchmark-tools
  • postgres-lambda
  • master default
  • REL9_4_25
  • REL9_5_20
  • REL9_6_16
  • REL_10_11
  • REL_11_6
  • REL_12_1
  • REL_12_0
  • REL_12_RC1
  • REL_12_BETA4
  • REL9_4_24
  • REL9_5_19
  • REL9_6_15
  • REL_10_10
  • REL_11_5
  • REL_12_BETA3
  • REL9_4_23
  • REL9_5_18
  • REL9_6_14
  • REL_10_9
  • REL_11_4
23 results

pg_backup_archiver.c

Blame
    • Tom Lane's avatar
      ed46d0d3
      Repair unsafe/unportable snprintf usage in pg_restore. · ed46d0d3
      Tom Lane authored
      warn_or_exit_horribly() was blithely passing a potentially-NULL
      string pointer to a %s format specifier.  That works (at least
      to the extent of not crashing) on some platforms, but not all,
      and since we switched to our own snprintf.c it doesn't work
      for us anywhere.
      
      Of the three string fields being handled this way here, I think
      that only "owner" is supposed to be nullable ... but considering
      that this is error-reporting code, it has very little business
      assuming anything, so put in defenses for all three.
      
      Per a crash observed on buildfarm member crake and then
      reproduced here.  Because of the portability aspect,
      back-patch to all supported versions.
      ed46d0d3
      History
      Repair unsafe/unportable snprintf usage in pg_restore.
      Tom Lane authored
      warn_or_exit_horribly() was blithely passing a potentially-NULL
      string pointer to a %s format specifier.  That works (at least
      to the extent of not crashing) on some platforms, but not all,
      and since we switched to our own snprintf.c it doesn't work
      for us anywhere.
      
      Of the three string fields being handled this way here, I think
      that only "owner" is supposed to be nullable ... but considering
      that this is error-reporting code, it has very little business
      assuming anything, so put in defenses for all three.
      
      Per a crash observed on buildfarm member crake and then
      reproduced here.  Because of the portability aspect,
      back-patch to all supported versions.